Improved minio support and updated documentation for running inside the cluster#487
Open
obervinov wants to merge 9 commits intoderailed:masterfrom
Open
Improved minio support and updated documentation for running inside the cluster#487obervinov wants to merge 9 commits intoderailed:masterfrom
obervinov wants to merge 9 commits intoderailed:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everyone! Thank you for this very useful tool, which significantly improves operational safety in my cases.
I recently deployed Popeye inside a Kubernetes cluster as a CronJob and use Minio as a repository for reports.
During testing, I identified a couple of areas for improvement, which I've already validated in my environment. I believe these changes could benefit the wider community:
Content-Typeof the uploaded objects was consistently set toapplication/octet-stream. For HTML reports, setting theContent-Typetotext/htmlallows users to open the reports directly in the browser via a direct link. I've implemented a change in s3.go to ensure the correctContent-Typeis set for HTML, JSON and YAML reports when uploading to Minio.Perhaps these enhancements will be valuable to others!