Conversation
After 4942da3 this is safe.
Fixes unicorn/no-object-as-default-parameter. url is optional and only checked for truthiness, so the empty default is equivalent.
Return undefined for absent values instead of false, and cast filter(Boolean) to string[] instead of using a type predicate.
joscha
approved these changes
Jun 9, 2026
joscha
left a comment
joscha
left a comment
Collaborator
There was a problem hiding this comment.
I think I prefer the old code, it conveys the intent more clear. But I am too worried either way.
Member
Author
|
You mean regarding the optional chain? I can revert it, I'm in between, myself :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@joscha: unsure 100% if I prefer optional chaining here, but it should be the same regarding correctness and perf.
For the rest of the changes, I checked the generated file and it seems they are identical, minus the
constchange.Let me know what you think :)