Skip to content

fix gr109 - #5235

Closed
shmuel44 wants to merge 10 commits into
masterfrom
fix_gr109
Closed

fix gr109#5235
shmuel44 wants to merge 10 commits into
masterfrom
fix_gr109

Conversation

@shmuel44

@shmuel44 shmuel44 commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

Related Issues

fixes:

Description

  • Fixed an issue where the GR109 validation reported all of a content item's supported modules as missing for a dependency, instead of only the modules genuinely unsupported by that dependency.

  • Fixed an issue where the GR109 validation listed every command used by a content item as incompatible, instead of only the commands that are genuinely module-incompatible.

@shmuel44
shmuel44 requested review from a team and RosenbergYehuda as code owners February 3, 2026 07:36
@content-bot

Copy link
Copy Markdown
Contributor

Hi @shmuel44, This PR has been inactive for 50 days and is now marked as stale.
Please push a new commit or add a comment to keep it open.

@content-bot content-bot closed this Apr 6, 2026
@content-bot

Copy link
Copy Markdown
Contributor

Closing due to inactivity. If needed, please reopen.

@content-bot
content-bot deleted the fix_gr109 branch May 5, 2026 05:41
@shmuel44
shmuel44 restored the fix_gr109 branch June 14, 2026 12:22
@shmuel44 shmuel44 reopened this Jun 14, 2026
@coveralls

coveralls commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 27604214959

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Warning

No base build found for commit e0aec2d on master.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 86.168%

Details

  • Patch coverage: 2 uncovered changes across 1 file (51 of 53 lines covered, 96.23%).

Uncovered Changes

File Changed Covered %
demisto_sdk/commands/validate/validators/GR_validators/GR109_is_supported_modules_compatibility.py 32 30 93.75%
Total (3 files) 53 51 96.23%

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 56928
Covered Lines: 49054
Line Coverage: 86.17%
Coverage Strength: 1.72 hits per line

💛 - Coveralls

@github-actions

Copy link
Copy Markdown

Changelog(s) in markdown:

  • Fixed an issue where the GR109 validation reported all of a content item's supported modules as missing for a dependency, instead of only the modules genuinely unsupported by that dependency. #5235
  • Fixed an issue where the GR109 validation listed every command used by a content item as incompatible, instead of only the commands that are genuinely module-incompatible. #5235

@content-bot content-bot closed this Aug 6, 2026
@content-bot

Copy link
Copy Markdown
Contributor

Closing due to inactivity. If needed, please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants