Fix/warnings stacklevel mvapich runner#7949
Conversation
This reverts commit ff88670. Co-authored-by: nathon-lee <248585198+nathon-lee@users.noreply.github.com>
Revert "fix: update 1 file reformatted." (ff88670)
This reverts commit b90aee5.
Revert accidental Muon optimizer code re-introduction from copilot PRs
Signed-off-by: nathon-lee <leejianwoo@gmail.com>
|
Hi @nathon-lee, |
Hi @tohtana, you're right — stacklevel=2 still points inside DeepSpeed, and since a RuntimeError is raised right after, users won't even see the warning. This change has no real effect. Converting to draft while I reconsider. Thanks! |
|
@nathon-lee do you intend to keep this as draft? |
|
Hi, @sfc-gh-truwase |
|
@nathon-lee can you clarify that your reconsideration based on @tohtana comment is to merge even if there is no functional impact? |
|
Hi @tohtana and @sfc-gh-truwase, Thanks for the review. After revisiting the call path, I agree with your point: stacklevel=2 does not actually point to user code in this case, so this change does not provide meaningful user-facing value. Since the launcher also raises a RuntimeError immediately afterward, I do not think this PR is worth keeping open as-is. I will close it for now rather than keep a low-impact change under review. Thanks again for the careful feedback. If useful, I can come back later with a more meaningful improvement to the MVAPICH error/reporting path. |
MVAPICHRunner.backend_existscallswarnings.warnwithoutstacklevel,so Python reports the warning as coming from inside DeepSpeed rather than
the user's code. Adding
stacklevel=2fixes the reported call site.No functional change.