Bump row count upper bounds for games, club_games, and player_valuations - #365
Open
dcaribou wants to merge 3 commits into
Open
Bump row count upper bounds for games, club_games, and player_valuations#365dcaribou wants to merge 3 commits into
dcaribou wants to merge 3 commits into
Conversation
The dataset has grown past the 650000 ceiling again, causing CI failures. Commit 86f7466 reverted from 850000 to 650000 after fixing a data bug that had temporarily inflated the count, but with weekly market value updates the data has now naturally grown past 650000 again. https://claude.ai/code/session_01JCNzg11jxfNSqXVrQKn19D
The March 24 data update (scraper + API) pushed the master build past multiple test thresholds. The build has been failing since commit 2f0ad69 while it was passing at c4c4ac2 (March 23). Changes: - player_valuations: 650000 → 850000 (data grew past previous ceiling) - games: 82000 → 95000 (grew with Euro tournament games + regular updates) - club_games: 176000 → 190000 (proportional to games growth) https://claude.ai/code/session_01JCNzg11jxfNSqXVrQKn19D
dcaribou
changed the title
Break the monolithic "Run tests" step into separate steps (dvc pull, pytest, dbt build) and capture dbt output to GitHub Actions summary on failure. This will reveal which specific dbt test is failing. https://claude.ai/code/session_01JCNzg11jxfNSqXVrQKn19D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The master build has been failing since the March 24 data update (commit 2f0ad69). The last passing build was on commit c4c4ac2 (March 23). The regular data acquisition plus the recently added Euro tournament games pushed multiple tables past their test thresholds.
player_valuations: 650,000 → 850,000 (data grew past previous ceiling after 86f7466 reverted it)games: 82,000 → 95,000 (grew with Euro tournament games + regular weekly updates)club_games: 176,000 → 190,000 (proportional to games growth)Test plan
https://claude.ai/code/session_01JCNzg11jxfNSqXVrQKn19D