Draft
Conversation
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @faaabi963 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces core support for Amazon Athena in MetricFlow, enabling Athena as a first-class SQL engine option. The implementation covers the core engine infrastructure, adapter integration, build configuration, and documentation updates, paving the way for Athena-based development and testing workflows. The most important changes are grouped below:
Athena Engine Support and SQL Rendering:
ATHENAto theSqlEngineenum inmetricflow/protocols/sql_client.py, including Athena-specific unsupported granularities (nanosecond, microsecond). [1] [2]AthenaSqlExpressionRendererandAthenaSqlPlanRendererin the new filemetricflow/sql/render/athena.py, with Athena-specific SQL syntax for UUIDs, date/time handling, percentiles, and edge cases.Adapter Registration and Integration:
dbt-metricflow/dbt_metricflow/cli/dbt_connectors/adapter_backed_client.pyto register Athena as a supported adapter type, map it to the new SQL engine and renderer, and import the new renderer. [1] [2] [3] [4]Build Configuration and Testing:
dbt-athena) topyproject.toml, and new Makefile targets for Athena-based testing and schema population. [1] [2]Documentation Updates:
CLAUDE.md.ATHENA_IMPLEMENTATION_PLAN.md.These changes lay the foundation for Athena support in MetricFlow, with further work planned for Athena-specific testing, snapshots, and integration validation.