Fix for not having to chunk decode answer from server#7
Open
X-Ryl669 wants to merge 1 commit intodavidgfnet:masterfrom
Open
Fix for not having to chunk decode answer from server#7X-Ryl669 wants to merge 1 commit intodavidgfnet:masterfrom
X-Ryl669 wants to merge 1 commit intodavidgfnet:masterfrom
Conversation
Reduce UART speed used so it's possible to capture it via a serial terminal and UART adapter
Owner
|
The server already takes care of not sending chunked responses. I agree that using HTTP1.0 works in any case but it seems a bit dodgy to me. Also unrelated change (baud rate change!) |
Contributor
Author
|
It does for Apache because it does not chunk if the content length is known beforehand (this is not the case with the other servers however). Because the compression is not known beforehand, it's not very clean to set up a fixed content-length there. With the upcoming patches to remove the "fixed" content-length server side, this is required to avoid chunking. Right, without the baud rate change, it can't debug the stuff, but I can split it in 2 PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, any HTTP/1.1 client must accept chunked encoded answer. For HTTP/1.0, it's not mandatory, and downgrading HTTP version to 1.0 is a lot less work than implementing chunked decoding on the ESP8266.
Also reduce UART speed used so it's possible to capture it via a serial terminal and UART adapter (115200 bauds is a standard rate for terminal, 460800 is not supported on mine). UART is not used anymore anyway for data transfer so it's a safe move.