lint: fix linting errors and CI job#774
Open
aensidhe wants to merge 1 commit intodavestephens:mainfrom
Open
Conversation
**What this PR does / why we need it**: Fixes CI job in Github actions and lint checks **Any other useful info**: I've forked `ansible-nas` to private fork several years ago and decided today to bring upstream changes to my fork. During that I've found out that `pre-commit` is configured for repo, several linters has been set up and there's a CI job, unfortunately, failing always. This is a PR with just lint fixes and nothing else. `var-naming[no-role-prefix]` in tests was suppressed, but any willing enthusiast can search for `# noqa:` and proceed with even more fixes. Anything that is the main code was fixed where it should be fixed. I also changed the CI job to use `pre-commit`, so dev and CI will use and run same code. Signed-off-by: Anatoly Popov <me@aensidhe.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes CI job in Github actions and lint checks. CI job
lintnow works as supposed to: now it's green.Any other useful info:
I've forked
ansible-nasto private fork several years ago and decided today to bring upstream changes to my fork. During that I've found out thatpre-commitis configured for repo, several linters has been set up and there's a CI job, unfortunately, failing always.This is a PR with just lint fixes and nothing else.
var-naming[no-role-prefix]in tests was suppressed, but any willing enthusiast can search for# noqa:and proceed with even more fixes.Anything that is the main code was fixed where it should be fixed.
I also changed the CI job to use
pre-commit, so dev and CI will use and run same code.