feat: wire up dns controllers#2
Merged
zachsmith1 merged 1 commit intofeat/initdnsfrom Nov 22, 2025
Merged
Conversation
zachsmith1
force-pushed
the
feat/dnsimpl
branch
from
9618787 to
79924df
Compare
zachsmith1
force-pushed
the
feat/dnsimpl
branch
from
a1d2743 to
aa4f28d
Compare
zachsmith1
force-pushed
the
feat/dnsimpl
branch
from
e5aaaa3 to
eba1431
Compare
joshlreese
reviewed
Nov 18, 2025
joshlreese
left a comment
joshlreese
left a comment
There was a problem hiding this comment.
Nearly done with the review - will come back to this soon. Wanted to submit what I have so far.
joshlreese
previously approved these changes
Nov 19, 2025
joshlreese
approved these changes
Nov 22, 2025
joshlreese
left a comment
joshlreese
left a comment
There was a problem hiding this comment.
Approving, though I think we should follow up on some of the comments I made around avoiding GenerateName. There's also minor items that could be fixed up in this PR, but I won't block on those considering I know there's a refactor coming for the new downstream recordset reconciler.
joshlreese
approved these changes
Nov 22, 2025
zachsmith1
force-pushed
the
feat/dnsimpl
branch
from
225f231 to
97bdfae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial wiring for DNS controllers, config, and local deployments