ci: Switch to use windows-2025 instead of windows-2022#241
Merged
yarikoptic merged 6 commits intomasterfrom Jan 5, 2026
Merged
ci: Switch to use windows-2025 instead of windows-2022#241yarikoptic merged 6 commits intomasterfrom
yarikoptic merged 6 commits intomasterfrom
Conversation
to avoid needing to 'catch up'.
=== Do not change lines below ===
{
"chain": [],
"cmd": "git sedi windows-2022 windows-2025",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
NSIS is not pre-installed on Windows Server 2025 runner images unlike older Windows 2019/2022 images. This caused makensis to fail with "createProcess: does not exist" error when building the installer. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
When using bash shell in GitHub Actions on Windows, chocolatey's PATH updates aren't reflected in the current bash session. Use PowerShell for the install step and explicitly add NSIS path to GITHUB_PATH so subsequent bash steps can find makensis. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Windows Server 2025 has OpenSSH pre-installed by default (unlike 2022). The old approach of downloading OpenSSH v7.6.1.0p1-Beta from 2018 and running install-sshd.ps1 conflicts with the built-in version. Now we just start the pre-installed sshd service. The firewall rule is also created automatically on Windows 2025. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
yarikoptic
force-pushed
the
enh-upgade-windows
branch
from
a29f16a to
9576973
Compare
The "Fire up service" step using `net start sshd` is now redundant since we already start the service in the "Start OpenSSH server" step using PowerShell. Having both causes an error because the service is already running. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Windows OpenSSH requires admin users to have their authorized keys in C:\ProgramData\ssh\administrators_authorized_keys instead of the user's ~/.ssh/authorized_keys. The file also requires specific permissions (only SYSTEM and Administrators with Full Control). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
Author
|
woohoo! All green and tests pass Let's proceed with that new windows env |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to avoid needing to 'catch up'.