Try to work around lack of concurrency-safety in fsspec#82
Draft
Try to work around lack of concurrency-safety in fsspec#82
Conversation
Codecov ReportBase: 70.69% // Head: 70.14% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #82 +/- ##
==========================================
- Coverage 70.69% 70.14% -0.56%
==========================================
Files 11 11
Lines 761 767 +6
==========================================
Hits 538 538
- Misses 223 229 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
yarikoptic
reviewed
Nov 15, 2022
datalad_fuse/fuse_.py
Outdated
| try: | ||
| fsspec_file.close() | ||
| except KeyError: | ||
| pass |
Member
There was a problem hiding this comment.
FWIW if we are to proceed this way, would be worth adding at least DEBUG level log messages so we have some track of those
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See fsspec/filesystem_spec#1107 (comment)