Open
Conversation
Contributor
Author
jperezlatimes
requested changes
Mar 26, 2025
lib/index.js
Outdated
|
|
||
| preppedData.assets[normalizedAssetType][normalizedAssetName][ext] = | ||
| this.getStaticPath(path); | ||
| if (path && path.length > 0) { |
Contributor
There was a problem hiding this comment.
just check if (path), this will catch undefined, null, and empty strings. If there is no path we should show an error or warning. So code should look like:
if (!path) {
console.error(`Could not find static path for asset :${normalizedAssetName} and path: ${path}`);
return;
}
preppedData.assets[normalizedAssetType][normalizedAssetName][ext] = this.getStaticPath(path);
Contributor
Author
There was a problem hiding this comment.
We implemented this suggestion and tweaked the error message. We made it into a warning instead because the error message being in red felt like it would be an error that would stop the build, but it's not.
if (!path) {
console.warn(
`Could not find static path for asset: ${normalizedAssetName} with the extension: ${ext}. Skipping.`
);
return;
}Is there a way to maybe run npm start with both a quiet version and a --verbose version that prints out the warnings? If your crosswalk has a lot of different file types, the warnings can be a little overwhelming, and it may be useful to have an option to show only errors instead of warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.