Route MCP tool calls to mixer agent apis#201
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for Mixer-side agent endpoints as an alternative to local processing, controlled by the USE_MIXER_AGENT_APIS configuration flag. It adds a new MixerClient for async communication, service and tool layers for fetching observations and searching indicators, and corresponding integration tests. Feedback on these changes suggests improving the LLM instructions in search_indicators.md by replacing the fictional parent place 'Middle Earth' with a real-world entity, and enhancing the robustness of MixerClient.post by handling network and JSON parsing errors while preventing potential sensitive data exposure in logs.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
clincoln8
left a comment
There was a problem hiding this comment.
Let's go!
Consider removing the prefix "mixer" everywhere and replace with something like "api" or "agent_api"
Thanks! Renamed to "agent_api". |
USE_MIXER_AGENT_APISenv var to enable direct routing to Mixer-side agent endpoints.MixerClientto perform async POST requests with timing logging.mixer_servicefunctions to communicate directly withagent/get_observationsandagent/search_indicatorsendpoints.mixer_toolsto expose tool signatures without legacy parameters likemaybe_bilateral.Testing on staging
USE_MIXER_AGENT_APIS=true