Switch over to .parquet files to back a Region2Vec dataset#15
Closed
Switch over to .parquet files to back a Region2Vec dataset#15
.parquet files to back a Region2Vec dataset#15Conversation
Added backend search
Release 0.3.0
New RegionSet from gtars
Better batching strategy for Region2Vec `encode` function
Release Atacformer
khoroshevskyi
requested changes
Sep 6, 2025
Member
khoroshevskyi
left a comment
khoroshevskyi
left a comment
There was a problem hiding this comment.
Everything looks good, but we need to fix tests
Member
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This directly addresses #14.
Briefly, it changes the
Region2VecDatasetfrom requiring a folder of.gtokfiles to a single.parquetfile. I've also updated the documentation to support this change.TODO: