fix: handle empty IEJoin outer fill#19604
Open
sundy-li wants to merge 1 commit intodatabendlabs:mainfrom
Open
Conversation
Contributor
|
At least one test kind must be checked in the PR description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Changes
RangeJoinState.fill_outer()to derive the null-padded inner columns from the output schema slices for left/right joins.Tests
cargo test -p databend-query test_fill_outer_with_empty_inner_table_blocks --lib -- --nocapturecargo test -p databend-query --test it test_iejoin_outer_join_with_empty_input -- --nocapturecargo clippy -p databend-query --lib -- -D warningsType of change
Fixes #19569
This change is