Fixed problems with newer PHP and ttrss versions#35
Closed
timholl wants to merge 2 commits intodasmurphy:masterfrom
timholl:master
Closed
Fixed problems with newer PHP and ttrss versions#35timholl wants to merge 2 commits intodasmurphy:masterfrom timholl:master
timholl wants to merge 2 commits intodasmurphy:masterfrom
timholl:master
Conversation
Author
|
Didn't notice the repository change, nevermind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem 1
Two fixes, a missing
self::s (will not work in current PHP versions) and a missingArticle::(the latter is also addressed in two other (rather stale) pull requests, A, B.)Problem 2
Since some refactoring in ttrss the mother
Handlerclass lost itsdbh(database handle) property, which is used excessively by this plugin. Re-added the property locally in theFeverAPIclass and added initialization in the constructor.Note: this is a minimal-invasive workaround for refactoring the whole plugin to use a proper database connection. Since that, ttrss core will throw deprecation notices (
PHP Notice: Legacy connect requested to mysql in /var/www/html/classes/db.php on line 22), like hell.