chore: remove block_requested field from FitlerMatch

[ZocoLini]

Summary by CodeRabbit

• Refactor
  • Streamlined internal state tracking by removing redundant status indicators and consolidating to core data structures, reducing code complexity and improving maintainability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

The block_requested boolean field was removed from the FilterMatch struct definition and all related code paths. The struct now contains only block_hash and height fields, with usages updated across the sync matching logic and test code.

Changes

Cohort / File(s)	Summary
Struct Definition Removal dash-spv/src/types.rs	Removed pub block_requested: bool field from the FilterMatch struct; block_hash and height fields remain.
Usage Updates dash-spv/src/sync/filters/matching.rs	Eliminated all assignments and references to block_requested. FilterMatch instantiations now omit this field entirely; control flow relies solely on block_hash and height.
Test Updates dash-spv/tests/block_download_test.rs	Removed block_requested initialization from test helper and eliminated associated assertions validating the field's state.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A rabbit hops through matching.rs with glee,
Removing flags that cluttered the tree,
block_requested? Begone, I say!
Simpler structs light the way,
FilterMatch dances, now lean and spry! 🐰✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title describes the main change: removing the block_requested field from FilterMatch, which matches the changeset across all three affected files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 89fed4b and 22e09c5.

📒 Files selected for processing (3)

• dash-spv/src/sync/filters/matching.rs
• dash-spv/src/types.rs
• dash-spv/tests/block_download_test.rs

💤 Files with no reviewable changes (2)

• dash-spv/src/types.rs
• dash-spv/tests/block_download_test.rs

🧰 Additional context used

📓 Path-based instructions (3)

dash-spv/**/*.rs

📄 CodeRabbit inference engine (dash-spv/CLAUDE.md)

dash-spv/**/*.rs: Use async/await throughout the codebase, built on tokio runtime
Use Arc for trait objects to enable runtime polymorphism for NetworkManager and StorageManager
Use Tokio channels for inter-component message passing between async tasks
Maintain minimum Rust version (MSRV) of 1.89 and use only compatible syntax and features

Files:

• dash-spv/src/sync/filters/matching.rs

dash-spv/src/sync/**/*.rs

📄 CodeRabbit inference engine (dash-spv/CLAUDE.md)

Implement sequential phase-based synchronization via SyncManager with phases progressing in order: Headers → Masternode List → Filter Headers → Filters → Blocks

Files:

• dash-spv/src/sync/filters/matching.rs

**/*.rs

📄 CodeRabbit inference engine (AGENTS.md)

**/*.rs: MSRV (Minimum Supported Rust Version) is 1.89; ensure compatibility with this version for all builds
Unit tests should live alongside code with #[cfg(test)] annotation; integration tests use the tests/ directory
Use snake_case for function and variable names
Use UpperCamelCase for types and traits
Use SCREAMING_SNAKE_CASE for constants
Format code with rustfmt before commits; ensure cargo fmt --all is run
Run cargo clippy --workspace --all-targets -- -D warnings for linting; avoid warnings in CI
Prefer async/await via tokio for asynchronous operations

**/*.rs: Never hardcode network parameters, addresses, or keys in Rust code
Use proper error types (thiserror) and propagate errors appropriately in Rust
Use tokio runtime for async operations in Rust
Use conditional compilation with feature flags for optional features
Write unit tests for new functionality in Rust
Format code using cargo fmt
Run clippy with all features and all targets, treating warnings as errors
Never log or expose private keys in any code
Always validate inputs from untrusted sources in Rust
Use secure random number generation for keys

Files:

• dash-spv/src/sync/filters/matching.rs

🧠 Learnings (4)

📚 Learning: 2025-12-16T09:03:55.811Z

Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: dash-spv/CLAUDE.md:0-0
Timestamp: 2025-12-16T09:03:55.811Z
Learning: Applies to dash-spv/src/sync/**/*.rs : Implement sequential phase-based synchronization via SyncManager with phases progressing in order: Headers → Masternode List → Filter Headers → Filters → Blocks

Applied to files:

• dash-spv/src/sync/filters/matching.rs

📚 Learning: 2025-06-26T16:01:37.609Z

Learnt from: DCG-Claude
Repo: dashpay/rust-dashcore PR: 0
File: :0-0
Timestamp: 2025-06-26T16:01:37.609Z
Learning: The mempool tracking infrastructure (UnconfirmedTransaction, MempoolState, configuration, and mempool_filter.rs) is fully implemented and integrated in the Dash SPV client as of this PR, including client logic, FFI APIs, and tests.

Applied to files:

• dash-spv/src/sync/filters/matching.rs

📚 Learning: 2025-12-16T09:03:55.811Z

Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: dash-spv/CLAUDE.md:0-0
Timestamp: 2025-12-16T09:03:55.811Z
Learning: Applies to dash-spv/**/*.rs : Maintain minimum Rust version (MSRV) of 1.89 and use only compatible syntax and features

Applied to files:

• dash-spv/src/sync/filters/matching.rs

📚 Learning: 2025-12-16T09:03:55.811Z

Learnt from: CR
Repo: dashpay/rust-dashcore PR: 0
File: dash-spv/CLAUDE.md:0-0
Timestamp: 2025-12-16T09:03:55.811Z
Learning: Applies to dash-spv/src/storage/**/*.rs : Store headers in 10,000-header segments with index files in headers/ directory, filter headers and compact block filters in filters/ directory, and state in state/ directory

Applied to files:

• dash-spv/src/sync/filters/matching.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (17)

• GitHub Check: Windows / rpc
• GitHub Check: macOS / core
• GitHub Check: macOS / ffi
• GitHub Check: Ubuntu ARM / rpc
• GitHub Check: fuzz (dash_deserialize_amount)
• GitHub Check: fuzz (hashes_ripemd160)
• GitHub Check: fuzz (dash_deserialize_address)
• GitHub Check: fuzz (hashes_sha1)
• GitHub Check: fuzz (hashes_sha512_256)
• GitHub Check: fuzz (dash_deserialize_block)
• GitHub Check: fuzz (dash_outpoint_string)
• GitHub Check: fuzz (dash_deserialize_witness)
• GitHub Check: fuzz (dash_script_bytes_to_asm_fmt)
• GitHub Check: Pre-commit (macos-latest)
• GitHub Check: Pre-commit (windows-latest)
• GitHub Check: Address Sanitizer
• GitHub Check: Thread Sanitizer

🔇 Additional comments (2)

dash-spv/src/sync/filters/matching.rs (2)

224-226: LGTM! Good defensive error handling.

The explicit handling of the Option from VecDeque::remove() with a descriptive error message improves robustness, even though pos was just validated. This aligns with the coding guidelines for proper error propagation.

---

247-253: LGTM! Clean struct construction after field removal.

The FilterMatch is now correctly constructed with only block_hash and height fields, aligning with the PR objective. The comment explaining the unknown height for processing thread requests provides good context.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[xdustinface]

This will be gone soon so probably no point merging this?

[ZocoLini]

okey