New features#12
Open
Ali72 wants to merge 4 commits into
Open
Conversation
make didPan and didTap gestures public to support user custom pan/tap gestures from outside of the pod
feature: add an image to the slider feature: set position for slider's image style: add the image to each slider in the main storyboard
Owner
|
Thanks, I’m really excited to add this feature! Can you do a version that leaves the indentation as tabs? I can’t really see what changes you’ve made when the diff shows almost every line being rewritten. |
This reverts commit 8398738.
Ali72
commented
Jul 27, 2023
| } | ||
|
|
||
| @objc func didPan(sender: UIPanGestureRecognizer) { | ||
| @objc public func didPan(sender: UIPanGestureRecognizer) { |
Author
There was a problem hiding this comment.
when didPan function is public, I can set my custom drag gesture (like other view drag gestures) into the slider
Ali72
commented
Jul 27, 2023
| } | ||
|
|
||
| @objc func didTap(sender: UITapGestureRecognizer) { | ||
| @objc public func didTap(sender: UITapGestureRecognizer) { |
Author
There was a problem hiding this comment.
when didTap function is public, I can set my custom tap gesture (like other view taps) into the slider
Author
I removed all indentation and tabs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature: support custom pan and tab gesture
feature: disable slider drag option
feature: add an image to the slider
feature: set position for slider's image
style: add the image to each slider in the main storyboard