feat: Add new fields to conversation api#1640
Conversation
3b8b13b to
cc22ce8
Compare
Signed-off-by: Javier Aliaga <[email protected]>
cc22ce8 to
c75ca06
Compare
|
/LGTM .. all green so I think we can merge this |
siri-varma
left a comment
There was a problem hiding this comment.
@javier-aliaga Quick question, should we also update/create the conversation api examples with these new fields ?
|
@siri-varma the problem is these new fields are only supported by some components but not the echo service. I modified the examples to print the usage in case the model is present. Let me work on the ResponseFormat, I would like to do a real test |
a8c2386 to
5a5d394
Compare
Signed-off-by: Javier Aliaga <[email protected]>
5a5d394 to
4517391
Compare
|
@siri-varma I modified the examples to add the new fields, bear in mind this fields only works with a real llm, no changes expected using the echo service |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1640 +/- ##
============================================
+ Coverage 79.19% 79.24% +0.04%
- Complexity 2111 2136 +25
============================================
Files 229 233 +4
Lines 6360 6437 +77
Branches 695 697 +2
============================================
+ Hits 5037 5101 +64
- Misses 971 984 +13
Partials 352 352 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* feat: Add new fields to conversation api Signed-off-by: Javier Aliaga <[email protected]> * chore: Modify conversation examples Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]>
* feat: Add new fields to conversation api Signed-off-by: Javier Aliaga <[email protected]> * chore: Modify conversation examples Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Signed-off-by: salaboy <[email protected]>
* feat: Add new fields to conversation api Signed-off-by: Javier Aliaga <[email protected]> * chore: Modify conversation examples Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Signed-off-by: salaboy <[email protected]>
* feat: Add new fields to conversation api Signed-off-by: Javier Aliaga <[email protected]> * chore: Modify conversation examples Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Signed-off-by: salaboy <[email protected]>
* feat: Add new fields to conversation api Signed-off-by: Javier Aliaga <[email protected]> * chore: Modify conversation examples Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Signed-off-by: salaboy <[email protected]>
* feat: Add new fields to conversation api Signed-off-by: Javier Aliaga <[email protected]> * chore: Modify conversation examples Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Signed-off-by: salaboy <[email protected]>
* feat: Add new fields to conversation api Signed-off-by: Javier Aliaga <[email protected]> * chore: Modify conversation examples Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Signed-off-by: salaboy <[email protected]>
* feat: Add new fields to conversation api Signed-off-by: Javier Aliaga <[email protected]> * chore: Modify conversation examples Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Signed-off-by: salaboy <[email protected]>
* feat: Add new fields to conversation api Signed-off-by: Javier Aliaga <[email protected]> * chore: Modify conversation examples Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Signed-off-by: salaboy <[email protected]>
* feat: Add new fields to conversation api Signed-off-by: Javier Aliaga <[email protected]> * chore: Modify conversation examples Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Signed-off-by: salaboy <[email protected]>
* feat: Add new fields to conversation api Signed-off-by: Javier Aliaga <[email protected]> * chore: Modify conversation examples Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Signed-off-by: salaboy <[email protected]>
* adding spring boot 4.0.2 tests to the matrix Signed-off-by: salaboy <[email protected]> * removing ignoring autoconfig for hibernate and datasource Signed-off-by: salaboy <[email protected]> * adding spring-data-6 and spring-boot-4-starters Signed-off-by: salaboy <[email protected]> * adding spring-boot-4-sdk-tests to split dependencies Signed-off-by: salaboy <[email protected]> * new profile for sb4 Signed-off-by: salaboy <[email protected]> * Update master version to 1.18.0-SNAPSHOT Signed-off-by: Dapr Bot <[email protected]> Signed-off-by: salaboy <[email protected]> * feat: Add workflow versioning (#1624) Signed-off-by: Javier Aliaga <[email protected]> Signed-off-by: salaboy <[email protected]> * feat: Add new fields to conversation api (#1640) * feat: Add new fields to conversation api Signed-off-by: Javier Aliaga <[email protected]> * chore: Modify conversation examples Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Signed-off-by: salaboy <[email protected]> * feat: Add failure policy to actor reminders (#1643) * feat: Add failure policy to actor reminders Signed-off-by: Javier Aliaga <[email protected]> * chore: Use jackson to serialize/deserialize FailurePolicies Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]> Signed-off-by: salaboy <[email protected]> * updating version Signed-off-by: salaboy <[email protected]> * modifying integration tests steps for github workflow Signed-off-by: salaboy <[email protected]> * fixing workflow Signed-off-by: salaboy <[email protected]> * modified version on matrix Signed-off-by: salaboy <[email protected]> * modified values for matrix Signed-off-by: salaboy <[email protected]> * fix pom reference Signed-off-by: salaboy <[email protected]> * moving spring boot examples to integration tests Signed-off-by: salaboy <[email protected]> * removing code dependency between examples Signed-off-by: salaboy <[email protected]> * updating sb4 examples and deps Signed-off-by: salaboy <[email protected]> * Add PATCH constant to HttpExtension for service invocation (#1644) Signed-off-by: salaboy <[email protected]> * exclude spring6-data from java docs as it is not compatible with Spring Boot 3.x Signed-off-by: salaboy <[email protected]> * feat: Use dapr 1.17.0-rc.6 (#1651) * feat: Use dapr 1.17.0-rc.6 Signed-off-by: Javier Aliaga <[email protected]> * chore: Update pubsubIt to use resiliency policies Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Signed-off-by: salaboy <[email protected]> * fixing classpath for javadocs aggregation Signed-off-by: salaboy <[email protected]> --------- Signed-off-by: salaboy <[email protected]> Signed-off-by: Dapr Bot <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Co-authored-by: Javier Aliaga <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]> Co-authored-by: Paul Lindner <[email protected]>
* feat: Add new fields to conversation api Signed-off-by: Javier Aliaga <[email protected]> * chore: Modify conversation examples Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]>
* adding spring boot 4.0.2 tests to the matrix Signed-off-by: salaboy <[email protected]> * removing ignoring autoconfig for hibernate and datasource Signed-off-by: salaboy <[email protected]> * adding spring-data-6 and spring-boot-4-starters Signed-off-by: salaboy <[email protected]> * adding spring-boot-4-sdk-tests to split dependencies Signed-off-by: salaboy <[email protected]> * new profile for sb4 Signed-off-by: salaboy <[email protected]> * Update master version to 1.18.0-SNAPSHOT Signed-off-by: Dapr Bot <[email protected]> Signed-off-by: salaboy <[email protected]> * feat: Add workflow versioning (dapr#1624) Signed-off-by: Javier Aliaga <[email protected]> Signed-off-by: salaboy <[email protected]> * feat: Add new fields to conversation api (dapr#1640) * feat: Add new fields to conversation api Signed-off-by: Javier Aliaga <[email protected]> * chore: Modify conversation examples Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Signed-off-by: salaboy <[email protected]> * feat: Add failure policy to actor reminders (dapr#1643) * feat: Add failure policy to actor reminders Signed-off-by: Javier Aliaga <[email protected]> * chore: Use jackson to serialize/deserialize FailurePolicies Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]> Signed-off-by: salaboy <[email protected]> * updating version Signed-off-by: salaboy <[email protected]> * modifying integration tests steps for github workflow Signed-off-by: salaboy <[email protected]> * fixing workflow Signed-off-by: salaboy <[email protected]> * modified version on matrix Signed-off-by: salaboy <[email protected]> * modified values for matrix Signed-off-by: salaboy <[email protected]> * fix pom reference Signed-off-by: salaboy <[email protected]> * moving spring boot examples to integration tests Signed-off-by: salaboy <[email protected]> * removing code dependency between examples Signed-off-by: salaboy <[email protected]> * updating sb4 examples and deps Signed-off-by: salaboy <[email protected]> * Add PATCH constant to HttpExtension for service invocation (dapr#1644) Signed-off-by: salaboy <[email protected]> * exclude spring6-data from java docs as it is not compatible with Spring Boot 3.x Signed-off-by: salaboy <[email protected]> * feat: Use dapr 1.17.0-rc.6 (dapr#1651) * feat: Use dapr 1.17.0-rc.6 Signed-off-by: Javier Aliaga <[email protected]> * chore: Update pubsubIt to use resiliency policies Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Signed-off-by: salaboy <[email protected]> * fixing classpath for javadocs aggregation Signed-off-by: salaboy <[email protected]> --------- Signed-off-by: salaboy <[email protected]> Signed-off-by: Dapr Bot <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Co-authored-by: Javier Aliaga <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]> Co-authored-by: Paul Lindner <[email protected]>
* feat: Add new fields to conversation api Signed-off-by: Javier Aliaga <[email protected]> * chore: Modify conversation examples Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Signed-off-by: Javier Aliaga <[email protected]>
* adding spring boot 4.0.2 tests to the matrix Signed-off-by: salaboy <[email protected]> * removing ignoring autoconfig for hibernate and datasource Signed-off-by: salaboy <[email protected]> * adding spring-data-6 and spring-boot-4-starters Signed-off-by: salaboy <[email protected]> * adding spring-boot-4-sdk-tests to split dependencies Signed-off-by: salaboy <[email protected]> * new profile for sb4 Signed-off-by: salaboy <[email protected]> * Update master version to 1.18.0-SNAPSHOT Signed-off-by: Dapr Bot <[email protected]> Signed-off-by: salaboy <[email protected]> * feat: Add workflow versioning (dapr#1624) Signed-off-by: Javier Aliaga <[email protected]> Signed-off-by: salaboy <[email protected]> * feat: Add new fields to conversation api (dapr#1640) * feat: Add new fields to conversation api Signed-off-by: Javier Aliaga <[email protected]> * chore: Modify conversation examples Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Signed-off-by: salaboy <[email protected]> * feat: Add failure policy to actor reminders (dapr#1643) * feat: Add failure policy to actor reminders Signed-off-by: Javier Aliaga <[email protected]> * chore: Use jackson to serialize/deserialize FailurePolicies Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]> Signed-off-by: salaboy <[email protected]> * updating version Signed-off-by: salaboy <[email protected]> * modifying integration tests steps for github workflow Signed-off-by: salaboy <[email protected]> * fixing workflow Signed-off-by: salaboy <[email protected]> * modified version on matrix Signed-off-by: salaboy <[email protected]> * modified values for matrix Signed-off-by: salaboy <[email protected]> * fix pom reference Signed-off-by: salaboy <[email protected]> * moving spring boot examples to integration tests Signed-off-by: salaboy <[email protected]> * removing code dependency between examples Signed-off-by: salaboy <[email protected]> * updating sb4 examples and deps Signed-off-by: salaboy <[email protected]> * Add PATCH constant to HttpExtension for service invocation (dapr#1644) Signed-off-by: salaboy <[email protected]> * exclude spring6-data from java docs as it is not compatible with Spring Boot 3.x Signed-off-by: salaboy <[email protected]> * feat: Use dapr 1.17.0-rc.6 (dapr#1651) * feat: Use dapr 1.17.0-rc.6 Signed-off-by: Javier Aliaga <[email protected]> * chore: Update pubsubIt to use resiliency policies Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Signed-off-by: salaboy <[email protected]> * fixing classpath for javadocs aggregation Signed-off-by: salaboy <[email protected]> --------- Signed-off-by: salaboy <[email protected]> Signed-off-by: Dapr Bot <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Co-authored-by: Javier Aliaga <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]> Co-authored-by: Paul Lindner <[email protected]> Signed-off-by: Javier Aliaga <[email protected]>
* feat: Add workflow versioning (#1624) Signed-off-by: Javier Aliaga <[email protected]> * feat: Add new fields to conversation api (#1640) * feat: Add new fields to conversation api Signed-off-by: Javier Aliaga <[email protected]> * chore: Modify conversation examples Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> * feat: Add failure policy to actor reminders (#1643) * feat: Add failure policy to actor reminders Signed-off-by: Javier Aliaga <[email protected]> * chore: Use jackson to serialize/deserialize FailurePolicies Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> * Add PATCH constant to HttpExtension for service invocation (#1644) Signed-off-by: Javier Aliaga <[email protected]> * feat: Use dapr 1.17.0-rc.6 (#1651) * feat: Use dapr 1.17.0-rc.6 Signed-off-by: Javier Aliaga <[email protected]> * chore: Update pubsubIt to use resiliency policies Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> * chore: Fix Durable tasks flaky tests (#1653) * chore: Fix waitForLoopEvent test Signed-off-by: Javier Aliaga <[email protected]> * fix: Code style Signed-off-by: Javier Aliaga <[email protected]> * chore: Fix singleTimer Test Signed-off-by: Javier Aliaga <[email protected]> * chore: Fix LoopWithTimer Signed-off-by: Javier Aliaga <[email protected]> * fix: longTimer test Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> * chore: Update testcontainers (#1654) Signed-off-by: Javier Aliaga <[email protected]> * Spring workflow versioning (#1646) * feat: Spring workflow version support Signed-off-by: Javier Aliaga <[email protected]> * chore: Add workflow and activity annoations Signed-off-by: Javier Aliaga <[email protected]> * chore: Rename annotation Signed-off-by: Javier Aliaga <[email protected]> * chore: Fix spring boot examples Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> * Adding spring boot 4.0.2 tests to the matrix (#1638) * adding spring boot 4.0.2 tests to the matrix Signed-off-by: salaboy <[email protected]> * removing ignoring autoconfig for hibernate and datasource Signed-off-by: salaboy <[email protected]> * adding spring-data-6 and spring-boot-4-starters Signed-off-by: salaboy <[email protected]> * adding spring-boot-4-sdk-tests to split dependencies Signed-off-by: salaboy <[email protected]> * new profile for sb4 Signed-off-by: salaboy <[email protected]> * Update master version to 1.18.0-SNAPSHOT Signed-off-by: Dapr Bot <[email protected]> Signed-off-by: salaboy <[email protected]> * feat: Add workflow versioning (#1624) Signed-off-by: Javier Aliaga <[email protected]> Signed-off-by: salaboy <[email protected]> * feat: Add new fields to conversation api (#1640) * feat: Add new fields to conversation api Signed-off-by: Javier Aliaga <[email protected]> * chore: Modify conversation examples Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Signed-off-by: salaboy <[email protected]> * feat: Add failure policy to actor reminders (#1643) * feat: Add failure policy to actor reminders Signed-off-by: Javier Aliaga <[email protected]> * chore: Use jackson to serialize/deserialize FailurePolicies Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: salaboy <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]> Signed-off-by: salaboy <[email protected]> * updating version Signed-off-by: salaboy <[email protected]> * modifying integration tests steps for github workflow Signed-off-by: salaboy <[email protected]> * fixing workflow Signed-off-by: salaboy <[email protected]> * modified version on matrix Signed-off-by: salaboy <[email protected]> * modified values for matrix Signed-off-by: salaboy <[email protected]> * fix pom reference Signed-off-by: salaboy <[email protected]> * moving spring boot examples to integration tests Signed-off-by: salaboy <[email protected]> * removing code dependency between examples Signed-off-by: salaboy <[email protected]> * updating sb4 examples and deps Signed-off-by: salaboy <[email protected]> * Add PATCH constant to HttpExtension for service invocation (#1644) Signed-off-by: salaboy <[email protected]> * exclude spring6-data from java docs as it is not compatible with Spring Boot 3.x Signed-off-by: salaboy <[email protected]> * feat: Use dapr 1.17.0-rc.6 (#1651) * feat: Use dapr 1.17.0-rc.6 Signed-off-by: Javier Aliaga <[email protected]> * chore: Update pubsubIt to use resiliency policies Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Signed-off-by: salaboy <[email protected]> * fixing classpath for javadocs aggregation Signed-off-by: salaboy <[email protected]> --------- Signed-off-by: salaboy <[email protected]> Signed-off-by: Dapr Bot <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Co-authored-by: Javier Aliaga <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]> Co-authored-by: Paul Lindner <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> * chore: Update new pom.xml versions Signed-off-by: Javier Aliaga <[email protected]> * fix: pom version Signed-off-by: Javier Aliaga <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Signed-off-by: salaboy <[email protected]> Signed-off-by: Dapr Bot <[email protected]> Co-authored-by: salaboy <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]> Co-authored-by: Paul Lindner <[email protected]> Co-authored-by: Dapr Bot <[email protected]>
Description
Add new fields for conversation api
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1639
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: