Conversation
Signed-off-by: Matheus Cruz <[email protected]>
3dffdf6 to
7477f84
Compare
|
@mcruzdev so this change in Quarkus works? |
|
@javier-aliaga @dapr/maintainers-java-sdk Can we approve and merge this, as this is blocking the quarkus integration. |
|
So this is not a problem with CVEs but for native compilation, isnt it? I do not this PR introduces a lot of changes, so I am ok to merge it and give it a try. |
|
@javier-aliaga This is for native compilation... let's merge it and see... if this cause any issues, we are not catching them with the pipelines.. so it is a good test. |
|
@siri-varma can you please approve this? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1543 +/- ##
============================================
+ Coverage 76.91% 78.49% +1.58%
- Complexity 1592 1913 +321
============================================
Files 145 215 +70
Lines 4843 5827 +984
Branches 562 649 +87
============================================
+ Hits 3725 4574 +849
- Misses 821 916 +95
- Partials 297 337 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Matheus Cruz <[email protected]>
Signed-off-by: Matheus Cruz <[email protected]> Signed-off-by: sirivarma <[email protected]>
Description
I am not sure if this one is the best way to solve some issues related to native compilation. For Spring Native and Quarkus the
grpc-netty-shadedis not recommended due to recents CVEs and a lot of GraalVM configurations and substitutions.I am not an expertise in the netty subject, I appreciate any suggestions and comments about this change.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: