Skip to content

Conversation

@joshm998
Copy link

@joshm998 joshm998 commented Jan 15, 2026

Description

Adds support for the fifoMessageGroupId field in request metadata for the SNS/SQS pubsub component.

Order of precedence:

  1. Request Metadata
  2. Component Metadata
  3. Generated

Issue reference

#3415

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@joshm998 joshm998 requested review from a team as code owners January 15, 2026 07:41
@joshm998 joshm998 changed the title Adds request fifoMessageGroupId for SNS/SQS (#3415) Adds request fifoMessageGroupId for SNS/SQS Jan 15, 2026
Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @joshm998 thx for the PR here 🎉

Can you add a test to pubsub/aws/snssqs/snssqs_test.go and fix the linter issue?

@cicoyle cicoyle added this to the v1.17 milestone Jan 16, 2026
@joshm998
Copy link
Author

Hey @cicoyle no problem, added tests for testing the message group id precedence and fixed the linting issue.

@joshm998 joshm998 requested a review from cicoyle January 21, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants