Closed
Conversation
Remove phantomjs from package.json. Add testing instruction.
…ions taken into account and mergeable with master.
Collaborator
Author
|
There appear to be some extra commits in here. Working to slim this down to simply the granularity changes |
Collaborator
Author
|
Closing this to create this PR from another branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes the content from #777 and addresses most of the initial feedback from @danvk. As requested, assertions have been added for each new level of granularity, and an example has been added for the new sub-second granularity labelling logic.