add the ability to highlight multiple series with setSelection#805
Open
kchengsf wants to merge 1 commit intodanvk:masterfrom
kchengsf:master
Open
add the ability to highlight multiple series with setSelection#805kchengsf wants to merge 1 commit intodanvk:masterfrom kchengsf:master
kchengsf wants to merge 1 commit intodanvk:masterfrom
kchengsf:master
Conversation
Owner
|
@klausw any thoughts on this? Seems fine to me other than style guide issues. |
Contributor
|
I think this looks good, and it's functionality I've been wanting myself. I don't have a strong preference about the implementation. There may be useful followups such as restricting interactive highlighting to switch among the selected series, assuming that this isn't already working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to add the ability to highlight multiple series in setSelection.
I've added a test and updated relevant documentation parts to accommodate this, however there are quite a few ways this could be implemented. Please let me know if a different approach makes more sense. In particular, repeatedly calling _renderLineChart is cleaner but requires iteration through all series each call. Moving the logic downward requires the method to understand the nuance between an array vs string option.