Open
Conversation
* flex fix try 2 * fix height
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Site URL (Test Yourself!)
https://simon-says-solder-fork.vercel.app/
Changes
Ok I kinda cheated because I snuck other fixes into here like adjusting start button size, but in general, this PR is for adding functionality for seeing musical note labels to each button.
Since this arguably goes against the point of the game (but is nice as a musician) I have added this as a toggle, and it is opt out by default.
Debugging Info for Danny
I tested this in Vercel Preview Environment (https://vercel.com/features/previews) on non-main branches to avoid breaking production.
For some reason I can't make it run locally very well. That's ok though, this is simple web app so it's easy to quickly deploy and test on Vercel Preview. Good CI / CD workflow.
I am also using Right Click > Inspect Element > Edit in HTML to quickly test some changes without having to push commits.
Finally remember to always pull request features to main branch.
Misc PR advice for Danny
Pull new changes on main. Make new branch when you have new feature.
Avoid stuff like "pull request for feature 1" > "pull request for feature 2 out of feature 1 branch before feature 1 is merged into main".
Always merge into main as often as you can.
New features should only branch off of main and not other branches.
Maintain a singular source of truth if you can.
Document your software testing thoroughly
Issues
Strictly speaking you should add a github issues before PR so you can track problems and fixes separate (https://github.com/dannyothello/Simon-Says-Color-Pattern-Game/issues), but I got lazy.
Squash and Merge
Please feel free to click "squash and merge" below for clean git history on main (don't want too many commit). The original singular commits are in the original branch so don't worry about losing any code history.
More info -https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges#squash-and-merge-your-commits