Fix: Cast LazyString to str before DB commit#97
Open
jilkka wants to merge 1 commit intodannymcc:mainfrom
Open
Conversation
Added force_string validator to ensure label is string before DB commit.
|
I can confirm this is still happening on v0.15.0 using the Docker image on a Synology NAS. What I found:
Relevant log output: Thanks for the fix in PR #97 — happy to test once it makes it into a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added force_string validator to ensure label is string before DB commit.
Summary
Fixed a 500 Internal Server Error occurring when adding vehicle specifications during new vehicle creation and adding to existing vehicle.
LazyStrings were being passed directly to SQLite resulting in crash.
Changelog
Added: A @validates decorator in models.py to automatically cast specification labels to standard strings before they reach the database.
Fixed: sqlalchemy.exc.ProgrammingError when saving predefined vehicle spec types during new vehicle creation and after.
Testing
How were these changes tested?