fix: resetting buffer for atari correctly#213
Open
Anton-Gasse wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was playing around with the Atari environment I found this little issue when resetting the buffer.
I think the intended behavior is to replace everything in the buffer with the first observation.
However, when the pooling parameter (buffer size) was > 1 then the first element is iteratively overwritten with the other Elements in the buffer (which are initially arrays with only zeros) and therefore the first observation is always a black image.
The error seems to be putting the self.buffers[0] and dst parameters for the np.copyto() method in the wrong order.
According to the numpy documentation the first parameter should be the destination and the second one the source: https://numpy.org/doc/stable/reference/generated/numpy.copyto.html
The implemented switch in this commit should fix this.
I tested it by adding this little testing script to the main.py file and observed that now the first observation is actually an image from the environment and not a black image:
I have not tested yet if that change influences any model behavior in the environment.
Hope to hear from you about, if that is helpful.
Cheers,
Anton