v0.17.1 - Migrate sample sources and remove websfz format support#116
Merged
v0.17.1 - Migrate sample sources and remove websfz format support#116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample Sources Migration — Summary
Create with Claude code
Goal
Migrate all instruments from
danigb.github.io/samplestosmpldsnds.github.iorepos, then remove the legacy websfz pipeline.Completed
SplendidGrandPiano
src/splendid-grand-piano.tsBASE_URLtohttps://smpldsnds.github.io/sfzinstruments-splendid-grand-piano/samplesPP-C3->PP C3)MF(uppercase) for C#1-C4 andMf(mixed case) for low+high range%20) insrc/smplr/load-audio.tsformatsconfig (defaults to["ogg", "m4a"])ElectricPiano
src/electric-piano.tsSfzSampler— composesSmplrdirectly (same pattern asSmolken).sfzfiles from smpldsnds, converts withsfzToSmplrJson()formatsconfig (defaults to["ogg", "m4a"])smpldsnds.github.io/sfzinstruments-greg-sullivan-e-pianos/cp80/CP80.sfzsmpldsnds.github.io/sfzinstruments-greg-sullivan-e-pianos/planet-t/Pianet T.sfzsmpldsnds.github.io/sfzinstruments-greg-sullivan-e-pianos/wurlitzer-ep200/Wurlitzer EP200.sfzsmpldsnds.github.io/sgossner-vcsl/Electrophones/TX81Z - FM Piano.sfzSFZ Parser:
#definepreprocessorsrc/smplr/sfz-convert.tsresolveDefines()step before tokenization#define $VAR valuedirectives used by smpldsnds SFZ files (e.g.#define $EXT flac)Removed legacy websfz pipeline
All websfz support has been removed. The entire
src/sfz/directory was deleted along with the websfz converter:src/sfz/websfz.tssrc/sfz/sfz-kits.tssrc/sfz/sfz-load.tssrc/sfz/sfz-sampler.tssrc/sfz/sfz-regions.tssrc/sfz/sfz-regions.test.tssrc/sfz/__fixtures__/cp80.websfz.tssrc/sfz/__fixtures__/meatbass.tssrc/sfz/__fixtures__/grandpiano.tssrc/smplr/websfz-convert.tsNone of these were exported from the library.
SfzSamplerwas orphaned after the ElectricPiano rewrite (nothing imported it). The test fixtures andfindRegions()were only used bysfz-regions.test.ts.Already on smpldsnds (no changes needed)
smpldsnds.github.io/sfzinstruments-dsmolken-double-basssmpldsnds.github.io/sgossner-vcslsmpldsnds.github.io/archiveorg-mellotronsmpldsnds.github.io/drum-machinesDemo site improvements
smplr/package.jsondisplayed in page title