fix: include Grok in --search help text, completions, and locales#2140
Open
Resistor52 wants to merge 2 commits into
Open
fix: include Grok in --search help text, completions, and locales#2140Resistor52 wants to merge 2 commits into
Resistor52 wants to merge 2 commits into
Conversation
PR danielmiessler#2092 added Grok (xAI) web search support and updated the go-flags struct tag in internal/cli/flags.go, but `fabric --help` renders flag descriptions from the i18n message catalog (internal/cli/help.go maps "search" -> "enable_web_search_tool"), not from the struct tag. The catalog value was never updated, so --help, the zsh/fish completions, and the README help block still listed only Anthropic, OpenAI, Gemini, leaving the Grok support undiscoverable even though it works. Append "Grok" to the enable_web_search_tool value in all 11 locales (matching each locale's list separator), the zsh and fish completions, and the generated README help block. No functional change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
--searchsupports Grok (xAI) web search since #2092, butfabric --helpstill shows:The capability works (
-V GrokAI -m grok-4.3 --searchgrounds correctly), but the help text, shell completions, and README still omit Grok, so the support is undiscoverable.Root cause
--helprenders flag descriptions from the i18n message catalog, not the go-flags struct tag.internal/cli/help.gomaps the flag to a key:#2092 updated the struct tag in
internal/cli/flags.go(...Gemini, Grok)) but not the catalog value, so the rendered help kept the old vendor list.Change
Append
Grokto theenable_web_search_toolvalue in all 11 locales (matching each locale's list separator, including the full-width、forja/zhand the Arabic comma forfa), the zsh and fish completions, and the generated README help block. No functional change; 14 files, one line each.Test plan
go build ./cmd/fabric && ./fabric --help | grep -- --searchnow shows(Anthropic, OpenAI, Gemini, Grok).go test ./internal/i18n/...passes.🤖 Generated with Claude Code