Add Action CheckBox and Switch items#112
Open
kuba2k2 wants to merge 21 commits intodaniel-stoneuk:preferencesfrom
Open
Add Action CheckBox and Switch items#112kuba2k2 wants to merge 21 commits intodaniel-stoneuk:preferencesfrom
kuba2k2 wants to merge 21 commits intodaniel-stoneuk:preferencesfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for combined action and checkbox/switch items to the
preferencesbranch. The combined items contain a toggleable switch and a clickable action, depending on the clicked part of the item. This is inspired by a preference found in some places in the Android settings app, for example:The PR also enables toggling the switches by clicking anywhere on the item. It also refactors the XML layout code a bit and contains all changes up until the
3.1.2tag.Screenshot: