Fix transitive dependency ordering for asset graph - #34062
Open
bandish1304 wants to merge 2 commits into
Open
Conversation
Contributor
Greptile SummaryRefines transitive dependency ordering for virtual assets.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| python_modules/dagster/dagster/_core/execution/plan/plan.py | Replaces name-based ordering suppression with step-key and computation-identity checks, resolving the previously reported dropped dependency without exposing a distinct related failure. |
| python_modules/dagster/dagster_tests/execution_tests/execution_plan_tests/test_view_transitive_deps.py | Adds focused regression tests for distinct computations sharing names and split subsettable multi-assets connected through virtual and external assets. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Early["multi_asset: early"] --> View["view_mid (virtual)"]
View --> External["external_bridge"]
External --> Late["multi_asset: late"]
Early -. "same computation family: no extra ordering edge" .-> Late
Reviews (2): Last reviewed commit: "Refine computation-family comparison for..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes Issue #33764
Summary and Motivation
Makes execution planning more reliable by ensuring downstream assets wait for the right upstream work without introducing false self-dependencies or missed ordering edges.
This fixes execution-plan ordering for view-transitive dependencies in plan.py by preventing incorrect edge pruning and only skipping true same-computation self-ordering cases. The motivation is to avoid premature downstream execution or dependency cycles in subsettable multi-asset scenarios, with regression tests added to lock in the correct behavior in test_view_transitive_deps.py.
What changed
Testing