🐛 port number generation should not depend on the Locale (tests)#2323
Merged
🐛 port number generation should not depend on the Locale (tests)#2323
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
...n/java/fr/pilato/elasticsearch/crawler/plugins/FsCrawlerExtensionRemoteProviderAbstract.java
Outdated
Show resolved
Hide resolved
With some Locale it's failing to generate a good number. ```sh mvn integration-test -Dtests.seed=26635F93F291B78 -Dtests.class=fr.pilato.elasticsearch.crawler.fs.test.integration.elasticsearch.FsCrawlerRestIT -Dtests.method="uploadDocumentWithSshPlugin" -Dtests.locale=mni-Beng-IN ```
dadoonet
force-pushed
the
fix/readOptionalInt-locale
branch
from
30cafec to
2a2375b
Compare
|
dadoonet
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is happening with some Locale:
mvn integration-test -Dtests.seed=26635F93F291B78 -Dtests.class=fr.pilato.elasticsearch.crawler.fs.test.integration.elasticsearch.FsCrawlerRestIT -Dtests.method="uploadDocumentWithSshPlugin" -Dtests.locale=mni-Beng-INNote
Low Risk
Low risk: only adjusts integration test string formatting to be locale-stable; no production logic is changed.
Overview
Makes the SSH and FTP REST integration tests locale-independent by building the request JSON via
String.format(Locale.ROOT, ...)instead of text-block.formatted(...), ensuring numeric ports are always serialized as ASCII digits under non-English locales.Written by Cursor Bugbot for commit 2a2375b. This will update automatically on new commits. Configure here.