Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects SigV4 canonicalization for unsigned payload handling on non-presigned requests by checking the x-amz-content-sha256 header (rather than query parameters), and adds coverage around presigned URL behavior. It also removes an unused constant and ensures CI runs on pull requests.
Changes:
- Fix unsigned-payload detection for non-presigned requests to read
x-amz-content-sha256from headers. - Add presigned URL validation tests.
- Remove the unused
X-Amz-Content-Sha256query-parameter constant and run CI onpull_requestevents.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/canonical.rs |
Switches unsigned payload detection to header-based logic; adds a presigned URL canonicalization test. |
src/signature.rs |
Adds an integration-style test validating a presigned URL request where the body is ignored. |
src/constants.rs |
Removes the unused query-parameter constant for payload SHA. |
.github/workflows/rust.yml |
Triggers Rust CI on pull requests in addition to pushes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #16
This adds a unit test to validate the changes here and fixes some Git weirdness with a rebase on main.
Thanks to @FrancisRussell for this contribution!