refactor: move generateId to Entity options#77
Merged
tonyfromundefined merged 3 commits intomainfrom Mar 16, 2026
Merged
Conversation
Move the ID generation strategy from defineSchema to Entity as an option to better separate concerns. Schema now focuses purely on data structure and validation, while Entity handles runtime behavior (generateId, maxQueuedEvents). This improves consistency since maxQueuedEvents was already an Entity option. Co-Authored-By: Claude Haiku 4.5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move ID generation strategy from
defineSchematoEntityoptions to improve separation of concerns. Schema now focuses on data structure and validation, while Entity handles runtime behavior (generateId,maxQueuedEvents).This makes the API more consistent since
maxQueuedEventswas already an Entity option.Changes
generateIdfromdefineSchemaoptionsgenerateIdtoEntityoptions" $$generateId"from Schema typegenerateIdto Entity constructorAll 362 tests pass.
🤖 Generated with Claude Code