Conversation
Deploying stackflow-demo with
|
| Latest commit: |
a1eaf7a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2e61d720.stackflow-demo.pages.dev |
| Branch Preview URL: | https://changeset-release-main.stackflow-demo.pages.dev |
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis pull request releases version 1.3.2 of Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
commit: |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@core/CHANGELOG.md`:
- Line 7: Update the changelog entry to remove ambiguity by explicitly stating
the fix targets the aggregate call inside dispatchEvent (not store
initialization); change the sentence to mention "ensuring now >= eventDate in
the aggregate call within dispatchEvent" and keep references to
transitionDuration, eventDate, and dispatchEvent so reviewers can locate the
relevant logic (see aggregate call inside dispatchEvent and the separate
aggregate call during store initialization).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: d2f1a3c5-b55d-498e-9b8f-e31bfecf6034
📒 Files selected for processing (4)
.changeset/fix-transition-duration-zero-jitter.mdcore/CHANGELOG.mdcore/package.jsondocs/components/ChangelogContent.mdx
💤 Files with no reviewable changes (1)
- .changeset/fix-transition-duration-zero-jitter.md
|
|
||
| ### Patch Changes | ||
|
|
||
| - 0160f82: Fix intermittent incorrect transition state when `transitionDuration` is set to 0 by ensuring `now >= eventDate` in the initial aggregate call within `dispatchEvent`. |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify where aggregate(now) guards are applied in makeCoreStore
fd -i makeCoreStore.ts --exec rg -n -C3 'aggregate\(|Math\.max\(|new Date\(\)\.getTime\(\)'Repository: daangn/stackflow
Length of output: 790
Clarify wording in the release note to avoid confusion between store initialization and dispatchEvent.
The phrase "initial aggregate call within dispatchEvent" risks ambiguity. The store initialization (line 84) also calls aggregate without the guard, while dispatchEvent (lines 96-99) applies Math.max(newEvent.eventDate, new Date().getTime()) to ensure the condition. Reword to explicitly state the fix applies to the aggregate call inside dispatchEvent, not during store initialization. Example: "ensuring now >= eventDate in the aggregate call within dispatchEvent" (dropping "initial").
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@core/CHANGELOG.md` at line 7, Update the changelog entry to remove ambiguity
by explicitly stating the fix targets the aggregate call inside dispatchEvent
(not store initialization); change the sentence to mention "ensuring now >=
eventDate in the aggregate call within dispatchEvent" and keep references to
transitionDuration, eventDate, and dispatchEvent so reviewers can locate the
relevant logic (see aggregate call inside dispatchEvent and the separate
aggregate call during store initialization).
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
stackflow-docs | a1eaf7a | Commit Preview URL | Apr 03 2026, 03:09 AM |
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@stackflow/[email protected]
Patch Changes
transitionDurationis set to 0 by ensuringnow >= eventDatein the initial aggregate call withindispatchEvent.