Require explicit -k API key, add Ollama / Ollama‑Cloud handling, update docs#452
Open
hellocodelinux wants to merge 5 commits intod99kris:masterfrom
Open
Require explicit -k API key, add Ollama / Ollama‑Cloud handling, update docs#452hellocodelinux wants to merge 5 commits intod99kris:masterfrom
hellocodelinux wants to merge 5 commits intod99kris:masterfrom
Conversation
Updated get_api_key to accept service parameter and modified error messages. Added support for 'ollama' service in argument parsing.
Owner
|
Thanks for contributing (again)! 🙂 One concern with requiring API key as command-line argument is that they are frequently visible to other users on the same system (e.g. via Using an environment variable (or a dedicated secrets store/config file) is a more common practice for command line tools handling API keys, because it reduces accidental disclosure. Based on this I propose not requiring explicit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Rationale:
Testing
Please run these quick checks locally:
Notes / items for reviewer
If you’re happy with this approach, merge as-is. If you prefer env-var fallback or a different CLI UX for keys, say so and I will adjust.