Final fix: Playwright migration done and all tests passed#33
Open
shiragemalashri-shri wants to merge 1 commit intocytoscape:masterfrom
Open
Final fix: Playwright migration done and all tests passed#33shiragemalashri-shri wants to merge 1 commit intocytoscape:masterfrom
shiragemalashri-shri wants to merge 1 commit intocytoscape:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have migrated the engine from Puppeteer to Playwright to fix the viewport and screenshot issues we were facing.
Changes made:
Updated index.js to use Playwright logic (fixed setViewportSize and quality settings).
Updated package.json dependencies.
Verified everything by running npm test and all 11 tests passed successfully.
Please review and merge. Thanks!