ESLint: enforce trailing commas and html indentation#2125
ESLint: enforce trailing commas and html indentation#2125MetRonnie wants to merge 4 commits intocylc:masterfrom
Conversation
2f37040 to
3561bc2
Compare
|
Enforcing trailing commas is perhaps a little funky, but whatevs. Perhaps wait until we've flushed out the PR backlog and retry? |
We are already enforcing dangling commas in JavaScript file, this extends it to Vue SFCs. (As ESLint is a formatter, editors can be set up to automatically do this on save, or by |
Wow, hadn't even noticed?! But I may just be doing this anyway. |
|
Ah no I was wrong, before we were merely allowing dangling commas when on multiline arrays and objects (but if a trailing comma was left on a non-multiline array/object, the formatter would strip it). Now I've set it to enforce for multiline arrays/objects so that if a trailing comma is missing from a multiline array/object the formatter will add it (non-multiline dangling commas will still be stripped. This should make life easier as you can add entries to multiline arrays/objects without having to fiddle with missing dangling commas on the line above. |
So wait until 5 years time? 😅 Just force-pushed again |
Enough is enough 😄
See also #1536
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.?.?.xbranch.