Draft
Conversation
Member
Author
|
DRAFT: this change breaks a bunch of tests because it messes with the way sequential xtriggered tasks are managed, so I have to work through that (hopefully that's the only problem). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #7235
Close #5730
See #7235 (comment)
The correct way to do this is: for any task that is parentless in one or more recurrences, always spawn the next parentless instance (which may lie beyond multiple parented instances) out to the first parentless instance beyond the runahead limit.
In other words, we should treat the parentless instances of sometimes-parentless tasks the same way we treat always-parentless tasks, leaving parented instances to be spawned by their parents.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.