Logging: reduce duplication of jobs-submit cmd in scheduler log#7127
Draft
MetRonnie wants to merge 2 commits intocylc:masterfrom
Draft
Logging: reduce duplication of jobs-submit cmd in scheduler log#7127MetRonnie wants to merge 2 commits intocylc:masterfrom
MetRonnie wants to merge 2 commits intocylc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #3647
When investigating an issue, the repeated logging of a batch jobs-submit command was rather irritating and hampered looking through the scheduler log.
Repro
Have a workflow with lots of tasks that will be batch-submitted but will fail to submit.
Logging diff:
ERROR - [jobs-submit cmd] cylc jobs-submit --path=/bin --path=/usr/bin --path=/usr/local/bin --path=/sbin --path=/usr/sbin --path=/usr/local/sbin -- '$HOME/cylc-run/diamond/log/job' 1/foo_x01/01 1/foo_x02/01 1/foo_x03/01 1/foo_x04/01 1/foo_x05/01 1/foo_x06/01 1/foo_x07/01 1/foo_x08/01 1/foo_x09/01 1/foo_x10/01 [jobs-submit ret_code] 1 - [jobs-submit out] 2025-12-08T18:23:34Z|1/foo_x01/01|1| ERROR - [1/foo_x01/01:preparing] submission failed INFO - [1/foo_x01/01:preparing] => submit-failed WARNING - [1/foo_x01/01:submit-failed] did not complete the required outputs: x succeeded -ERROR - [jobs-submit cmd] cylc jobs-submit --path=/bin --path=/usr/bin --path=/usr/local/bin --path=/sbin --path=/usr/sbin --path=/usr/local/sbin -- '$HOME/cylc-run/diamond/log/job' 1/foo_x01/01 1/foo_x02/01 1/foo_x03/01 1/foo_x04/01 1/foo_x05/01 1/foo_x06/01 1/foo_x07/01 1/foo_x08/01 1/foo_x09/01 1/foo_x10/01 - [jobs-submit ret_code] 1 - [jobs-submit out] 2025-12-08T18:23:34Z|1/foo_x02/01|1| ERROR - [1/foo_x02/01:preparing] submission failed INFO - [1/foo_x02/01:preparing] => submit-failed WARNING - [1/foo_x02/01:submit-failed] did not complete the required outputs: x succeeded -ERROR - [jobs-submit cmd] cylc jobs-submit --path=/bin --path=/usr/bin --path=/usr/local/bin --path=/sbin --path=/usr/sbin --path=/usr/local/sbin -- '$HOME/cylc-run/diamond/log/job' 1/foo_x01/01 1/foo_x02/01 1/foo_x03/01 1/foo_x04/01 1/foo_x05/01 1/foo_x06/01 1/foo_x07/01 1/foo_x08/01 1/foo_x09/01 1/foo_x10/01 - [jobs-submit ret_code] 1 - [jobs-submit out] 2025-12-08T18:23:34Z|1/foo_x03/01|1| ERROR - [1/foo_x03/01:preparing] submission failed INFO - [1/foo_x03/01:preparing] => submit-failed WARNING - [1/foo_x03/01:submit-failed] did not complete the required outputs: x succeeded -ERROR - [jobs-submit cmd] cylc jobs-submit --path=/bin --path=/usr/bin --path=/usr/local/bin --path=/sbin --path=/usr/sbin --path=/usr/local/sbin -- '$HOME/cylc-run/diamond/log/job' 1/foo_x01/01 1/foo_x02/01 1/foo_x03/01 1/foo_x04/01 1/foo_x05/01 1/foo_x06/01 1/foo_x07/01 1/foo_x08/01 1/foo_x09/01 1/foo_x10/01 - [jobs-submit ret_code] 1 - [jobs-submit out] 2025-12-08T18:23:34Z|1/foo_x04/01|1| ERROR - [1/foo_x04/01:preparing] submission failed INFO - [1/foo_x04/01:preparing] => submit-failed WARNING - [1/foo_x04/01:submit-failed] did not complete the required outputs: x succeeded -ERROR - [jobs-submit cmd] cylc jobs-submit --path=/bin --path=/usr/bin --path=/usr/local/bin --path=/sbin --path=/usr/sbin --path=/usr/local/sbin -- '$HOME/cylc-run/diamond/log/job' 1/foo_x01/01 1/foo_x02/01 1/foo_x03/01 1/foo_x04/01 1/foo_x05/01 1/foo_x06/01 1/foo_x07/01 1/foo_x08/01 1/foo_x09/01 1/foo_x10/01 - [jobs-submit ret_code] 1 - [jobs-submit out] 2025-12-08T18:23:34Z|1/foo_x05/01|1| ERROR - [1/foo_x05/01:preparing] submission failed INFO - [1/foo_x05/01:preparing] => submit-failed WARNING - [1/foo_x05/01:submit-failed] did not complete the required outputs: x succeeded ...Check List
CONTRIBUTING.mdand added my name as a Code Contributor.?.?.xbranch.