Poll comms: always process standard outputs on poll#6599
Draft
MetRonnie wants to merge 6 commits intocylc:masterfrom
Draft
Poll comms: always process standard outputs on poll#6599MetRonnie wants to merge 6 commits intocylc:masterfrom
MetRonnie wants to merge 6 commits intocylc:masterfrom
Conversation
MetRonnie
force-pushed
the
poll-comms
branch
3 times, most recently
from
5b00e12 to
dd6c0c1
Compare
MetRonnie
force-pushed
the
poll-comms
branch
3 times, most recently
from
152e791 to
ab8166d
Compare
In case a task went through >1 state change since the last poll, always process the all outputs gleaned from the job poll info
cylc/flow/job_runner_mgr.py
Outdated
| from typing_extensions import Literal | ||
|
|
||
|
|
||
| @dataclass |
Member
There was a problem hiding this comment.
If switching to dataclass please turn slots on to match the original implementation (or revert to plain class).
Member
Author
There was a problem hiding this comment.
Ok, unfortunately slots cannot be used with default values in dataclasses until Python 3.10, so I have partially reverted and left a comment
MetRonnie
commented
Apr 10, 2025
| 'time_submit_exit', # submit (exit) time | ||
| 'time_run', # run start time | ||
| 'time_run_exit', # run exit time | ||
| 'job_runner_call_no_lines', # line count in job runner call stdout |
Member
Author
There was a problem hiding this comment.
job_runner_call_no_lines was unused
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case a task went through >1 state change since the last poll, always process the all outputs gleaned from the job poll info.
However this means that repeated polls will repeat the same outputs, so this PR also needs:
Also closes #6593
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.