Various small proposed improvements#909
Conversation
|
|
||
| .. tab-item:: CLI | ||
| :sync: gui | ||
| :sync: cli |
There was a problem hiding this comment.
Small mistake here caused tabs to sync incorrectly.
| from 1. | ||
| * ``P1`` is the :term:`recurrence`; a ``P1`` :term:`graph string` | ||
| repeats at every integer :term:`cycle point`. | ||
| tells Cylc to repeat at every integer :term:`cycle point`. |
There was a problem hiding this comment.
Minor change to keep consistency with other bullets.
| .. tip:: | ||
|
|
||
| We recommend using Mamba to install Cylc. | ||
| Mamba (or Micromamba) can be used as | ||
| `a faster, drop-in replacement for the conda command | ||
| <https://mamba.readthedocs.io/en/latest/index.html>`_. | ||
| If using Conda, make sure to use the libmamba-solver by updating to | ||
| Conda 23.10 or using the `conda-libmamba-solver plugin for conda | ||
| <https://conda.github.io/conda-libmamba-solver/getting-started/>`_. | ||
| The classic conda environment solver may be too slow for a complex package | ||
| like Cylc. |
There was a problem hiding this comment.
This tip is no longer relevant thanks to conda adopting the Libmamba dependency resolver
| mail events = failed | ||
| [[bell]] | ||
| script = printf 'bong%.02d\n' $(seq 1 $(cylc cyclepoint --print-hour)) | ||
| script = printf 'bong%.02d\n' $(seq 1 $(cylc cyclepoint --print-hour)); sleep 5 |
There was a problem hiding this comment.
Added sleep 5 to tutorial to allow users time to see the workflow running. A previous update to cylc sped up the running of this workflow significantly.
| * :term:`Families <family>` work best consolidating runtime configuration by | ||
| collecting tasks into broad groups, e.g. groups of tasks which run on a | ||
| particular machine or groups of tasks belonging to a particular system. | ||
| * `Jinja2`_ is good at configuring settings which apply to the entire workflow | ||
| rather than just a single task, as we can define variables then use them | ||
| throughout the workflow. | ||
| * :term:`Families <family>` work best consolidating runtime configuration by | ||
| collecting tasks into broad groups, e.g. groups of tasks which run on a | ||
| particular machine or groups of tasks belonging to a particular system. | ||
| * :term:`Parameterization <parameterization>` works best for describing tasks | ||
| which are very similar but which have subtly different configurations | ||
| (e.g. different arguments or environment variables). |
There was a problem hiding this comment.
Reorder to match toc tree
There was a problem hiding this comment.
GH should be showing this as outdated as the change is reverted in a following commit.
| .. image:: /tutorial/img/cylc-tools.png | ||
| :alt: A screenshot of several Cylc tools. | ||
| **Placeholder Images Currently Used** | ||
|
|
||
| .. tab-set:: | ||
|
|
||
| .. tab-item:: GUI | ||
|
|
||
| .. image:: ../../src/img/cylc-ui-dash.png | ||
| :alt: A screenshot of the Cylc GUI dashboard. | ||
| :width: 75% | ||
|
|
||
| .. tab-item:: Tui | ||
|
|
||
| .. image:: ../../src/img/tui-1.png | ||
| :alt: A screenshot of the Cylc TUI. | ||
| :width: 75% | ||
|
|
||
| .. tab-item:: CLI | ||
|
|
||
| .. image:: ../../src/img/cylc-cli.png | ||
| :alt: A screenshot of the Cylc CLI. | ||
| :width: 75% |
There was a problem hiding this comment.
I think these tabs are a little clearer and less intimidating than the combined image used before.
There was a problem hiding this comment.
Lots of small wording changes to clarify what is and is not installed via pip vs conda.
…xed a mistake on the interventions page causing tabs to not sync properly.
Added sleep 5 to a tutorial and added a description of why wallclock triggers are required to run tasks in real time.
…ion so the 2 places they are listed match.
b90fb1d to
609cff9
Compare
| jinja2 | ||
| families | ||
| parameters |
There was a problem hiding this comment.
This changes the order in which the tutorials are attempted.
Does this work?
There was a problem hiding this comment.
Try attempting the Jinja2 tutorial without first attempting the Families tutorial. There's a dependency between them.
The step numbers in the practicals outline the intended order:
- Families 1 & 2.
- Jinja2 3.
- Parameters 4.
The previous order was correct, i.e, it's the bit above which needs to change for consistency.
There was a problem hiding this comment.
Ah ok, I'll have another look.
If that is the case, and I think you are right, we are going to need to alter the toctree in a few places as currently, both the contents page and the menu go JinJa2 > Fam > Params. Currently, going page by page from the start will be JinJa2 > Fam.
Let me confirm the order 100% and I'll make that change.
Reducing duplicated explanations. Co-authored-by: Oliver Sanders <[email protected]>
Previous description sounded like the sleep 5 was important or changed the behaviour rather than emulating real behaviour.
|
Checks failing due to rate limit during linkcheck. |
The linkcheck test did fail, but not due to rate limiting. The message was: I.e, the site was down. |
Yep you're correct, the error starts: "Max retries exceeded with url" which I misinterpreted as a rate limit Do we need to investigate / correct this URL? |
|
Getting there: Still need to run through the tutorials again to check this all makes sense. I've definitely missed some bits. |
| .. ifslides:: | ||
|
|
||
| .. rubric:: This practical continues on from the | ||
| :ref:`Families practical <cylc-tutorial-families-practical>`. | ||
| :ref:`Jinja2 practical <cylc-tutorial-jinja2-practical>`. | ||
|
|
||
| Next section: :ref:`Which approach to use | ||
| <cylc-tutorial-consolidation-conclusion>` |
There was a problem hiding this comment.
It's currently inconsistent which pages make use of the ifslides / ifnotslides blocks. Are these still used for anything? I understood they were previously used for allowing the docs to generate in other formats but not sure if anything still uses them @oliver-sanders ? I can make an effort to clean them up if not, or add any missing if they are need. The JinJa2 page for example is missing some compared to the parametrization or families pages.
|
I have run through the tutorials multiple times and I think I am now happy with the order and the accompanying text. |

Requirements check-list
I have read
CONTRIBUTING.mdand added my name as a Code Contributor.Fixed a mistake on the interventions page causing tabs not to sync properly.
Adding tabs to the intro page to show different UI types. I find the current image a bit intimidating.
Added a note to Basic Cycling - Repeating Workflows to describe the reoccurrence in the example.