Skip to content

Various small proposed improvements#909

Open
samuel-denton wants to merge 13 commits intocylc:8.6.xfrom
samuel-denton:batch2_thoughts_on_docs
Open

Various small proposed improvements#909
samuel-denton wants to merge 13 commits intocylc:8.6.xfrom
samuel-denton:batch2_thoughts_on_docs

Conversation

@samuel-denton
Copy link
Copy Markdown
Contributor

@samuel-denton samuel-denton commented Feb 4, 2026

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.

  • Fixed a mistake on the interventions page causing tabs not to sync properly.

  • Adding tabs to the intro page to show different UI types. I find the current image a bit intimidating.

  • Added a note to Basic Cycling - Repeating Workflows to describe the reoccurrence in the example.


.. tab-item:: CLI
:sync: gui
:sync: cli
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small mistake here caused tabs to sync incorrectly.

Comment thread src/tutorial/scheduling/integer-cycling.rst Outdated
from 1.
* ``P1`` is the :term:`recurrence`; a ``P1`` :term:`graph string`
repeats at every integer :term:`cycle point`.
tells Cylc to repeat at every integer :term:`cycle point`.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change to keep consistency with other bullets.

Comment thread src/installation.rst
Comment on lines -22 to -32
.. tip::

We recommend using Mamba to install Cylc.
Mamba (or Micromamba) can be used as
`a faster, drop-in replacement for the conda command
<https://mamba.readthedocs.io/en/latest/index.html>`_.
If using Conda, make sure to use the libmamba-solver by updating to
Conda 23.10 or using the `conda-libmamba-solver plugin for conda
<https://conda.github.io/conda-libmamba-solver/getting-started/>`_.
The classic conda environment solver may be too slow for a complex package
like Cylc.
Copy link
Copy Markdown
Contributor Author

@samuel-denton samuel-denton Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#916 (comment)

This tip is no longer relevant thanks to conda adopting the Libmamba dependency resolver

mail events = failed
[[bell]]
script = printf 'bong%.02d\n' $(seq 1 $(cylc cyclepoint --print-hour))
script = printf 'bong%.02d\n' $(seq 1 $(cylc cyclepoint --print-hour)); sleep 5
Copy link
Copy Markdown
Contributor Author

@samuel-denton samuel-denton Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added sleep 5 to tutorial to allow users time to see the workflow running. A previous update to cylc sped up the running of this workflow significantly.

Comment thread src/tutorial/furthertopics/clock-triggered-tasks.rst Outdated
Comment on lines -157 to 167
* :term:`Families <family>` work best consolidating runtime configuration by
collecting tasks into broad groups, e.g. groups of tasks which run on a
particular machine or groups of tasks belonging to a particular system.
* `Jinja2`_ is good at configuring settings which apply to the entire workflow
rather than just a single task, as we can define variables then use them
throughout the workflow.
* :term:`Families <family>` work best consolidating runtime configuration by
collecting tasks into broad groups, e.g. groups of tasks which run on a
particular machine or groups of tasks belonging to a particular system.
* :term:`Parameterization <parameterization>` works best for describing tasks
which are very similar but which have subtly different configurations
(e.g. different arguments or environment variables).
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reorder to match toc tree

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GH should be showing this as outdated as the change is reverted in a following commit.

Comment on lines -93 to +113
.. image:: /tutorial/img/cylc-tools.png
:alt: A screenshot of several Cylc tools.
**Placeholder Images Currently Used**

.. tab-set::

.. tab-item:: GUI

.. image:: ../../src/img/cylc-ui-dash.png
:alt: A screenshot of the Cylc GUI dashboard.
:width: 75%

.. tab-item:: Tui

.. image:: ../../src/img/tui-1.png
:alt: A screenshot of the Cylc TUI.
:width: 75%

.. tab-item:: CLI

.. image:: ../../src/img/cylc-cli.png
:alt: A screenshot of the Cylc CLI.
:width: 75%
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these tabs are a little clearer and less intimidating than the combined image used before.

Comment thread src/installation.rst
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of small wording changes to clarify what is and is not installed via pip vs conda.

@samuel-denton samuel-denton marked this pull request as ready for review March 18, 2026 13:43
@samuel-denton samuel-denton requested a review from wxtim March 18, 2026 13:43
@samuel-denton samuel-denton added this to the 8.6.x milestone Mar 18, 2026
@samuel-denton samuel-denton force-pushed the batch2_thoughts_on_docs branch from b90fb1d to 609cff9 Compare March 18, 2026 14:55
@samuel-denton samuel-denton changed the base branch from master to 8.6.x March 18, 2026 14:56
@oliver-sanders oliver-sanders requested review from ChrisPaulBennett and oliver-sanders and removed request for wxtim April 9, 2026 14:12
Copy link
Copy Markdown

@ChrisPaulBennett ChrisPaulBennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cylc cylc deleted a comment from samuel-denton Apr 27, 2026
Comment on lines +145 to +147
jinja2
families
parameters
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the order in which the tutorials are attempted.

Does this work?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is just correcting the order in this sub-list so it matches the order elsewhere. This is section 3 in the image:

Image

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try attempting the Jinja2 tutorial without first attempting the Families tutorial. There's a dependency between them.

The step numbers in the practicals outline the intended order:

  • Families 1 & 2.
  • Jinja2 3.
  • Parameters 4.

The previous order was correct, i.e, it's the bit above which needs to change for consistency.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, I'll have another look.
If that is the case, and I think you are right, we are going to need to alter the toctree in a few places as currently, both the contents page and the menu go JinJa2 > Fam > Params. Currently, going page by page from the start will be JinJa2 > Fam.
Let me confirm the order 100% and I'll make that change.

Comment thread src/tutorial/scheduling/integer-cycling.rst Outdated
Reducing duplicated explanations.

Co-authored-by: Oliver Sanders <[email protected]>
Comment thread src/tutorial/furthertopics/clock-triggered-tasks.rst Outdated
Previous description sounded like the sleep 5 was important or changed the behaviour rather than emulating real behaviour.
@samuel-denton
Copy link
Copy Markdown
Contributor Author

samuel-denton commented Apr 27, 2026

Checks failing due to rate limit during linkcheck.

@oliver-sanders
Copy link
Copy Markdown
Member

oliver-sanders commented Apr 28, 2026

Checks failing due to rate limit during linkcheck.

The linkcheck test did fail, but not due to rate limiting. The message was:

Failed to establish a new connection: [Errno 101] Network is unreachable"))

I.e, the site was down.

@samuel-denton
Copy link
Copy Markdown
Contributor Author

samuel-denton commented Apr 28, 2026

Checks failing due to rate limit during linkcheck.

The linkcheck test did fail, but not due to rate limiting. The message was:

Failed to establish a new connection: [Errno 101] Network is unreachable"))

I.e, the site was down.

Yep you're correct, the error starts: "Max retries exceeded with url" which I misinterpreted as a rate limit

Do we need to investigate / correct this URL?

@samuel-denton
Copy link
Copy Markdown
Contributor Author

Getting there:
https://wwwspice/~samuel.denton/cylc-doc/batch2_thoughts_on_docs/html/tutorial/runtime/configuration-consolidation/index.html

Still need to run through the tutorials again to check this all makes sense. I've definitely missed some bits.

Comment on lines 182 to 188
.. ifslides::

.. rubric:: This practical continues on from the
:ref:`Families practical <cylc-tutorial-families-practical>`.
:ref:`Jinja2 practical <cylc-tutorial-jinja2-practical>`.

Next section: :ref:`Which approach to use
<cylc-tutorial-consolidation-conclusion>`
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's currently inconsistent which pages make use of the ifslides / ifnotslides blocks. Are these still used for anything? I understood they were previously used for allowing the docs to generate in other formats but not sure if anything still uses them @oliver-sanders ? I can make an effort to clean them up if not, or add any missing if they are need. The JinJa2 page for example is missing some compared to the parametrization or families pages.

@samuel-denton samuel-denton marked this pull request as ready for review April 30, 2026 16:20
@samuel-denton
Copy link
Copy Markdown
Contributor Author

samuel-denton commented Apr 30, 2026

I have run through the tutorials multiple times and I think I am now happy with the order and the accompanying text.
Only thing I have a question about is the slightly inconsistent use of ifslides / ifnotslides but not sure thats relavent to this PR anyway.
Please review alongside cylc/cylc-flow#7289 and close #924 if both are ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants