Extendable components / sprites without points don't break update#178
Open
benwiley4000 wants to merge 6 commits intocykod:masterfrom
Open
Extendable components / sprites without points don't break update#178benwiley4000 wants to merge 6 commits intocykod:masterfrom
benwiley4000 wants to merge 6 commits intocykod:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I apologize for including two separate features in one pull request - they ended up that way. I can separate the commits if needed, but they're each fairly small.
I adapted the existing component creation method to accommodate extension. Pass in the parent as the third argument. You can use the following to create a component called 'endlessRunnerControls' that inherits from 'platformerControls' but overrides the step function: