Wayland patch - #26
Conversation
Added simple arithmatic operators to artist::colour and a test
Copied axis point and rect methods over from elements:master branch
|
Wonderful! What I've been waiting for! |
|
|
Also, wouldn't it make sense to have BOTH GTK window AND Wayland window, with specific cmake flags to configure either? |
|
Fixed the failure of tests under Ubuntu. It won't be possible to fix it quickly on Windows, it will take time, there is something wrong with the linking at the build stage (artist.lib(harfbuzz.cpp.obj) : error LNK2005: roundf already defined in libucrt.lib(round.obj)). |
OK, agreed. GTK is not really necessary. That is a good point. But how about X11? Is that abandoned in this patch? (Pardon if it's a silly question. I haven't yet looked deeper) |
|
Yes, the x11 is not there. X server is considered an outdated technology and it will soon be stopped being included in distributions by default (maybe in 10 years), there is a lot of debate about this. X11 is very different from wayland, its support can be enabled via cmake. |
What does this mean, exactly? I didn't see any config switches. What am I missing? |
|
I'm sorry if I didn't put it right. X11 is not in the patch, I can add it if necessary. If you look at ubuntu, it has been using wayland by default for a long time, so Xorg support is not needed in new applications. |
Right. I think X11 is still needed for backward compatibility. Please do. Some people might rely on it. |
|
Ok. I'll get on it soon. |
That will be awesome! I really appreciate the work you're doing here! Many thanks! |
|
Should we just move forward and stop using X11? |
|
No, the big load is the window version.
вт, 2 сент. 2025 г. в 03:34, Joel de Guzman ***@***.***>:
… *djowel* left a comment (cycfi/artist#26)
<#26 (comment)>
Should we just move forward and stop using X11?
—
Reply to this email directly, view it on GitHub
<#26 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BBOYR5KLYOIXS56X3X5WZZD3QTQY5AVCNFSM6AAAAABZ76PQ4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTENBTGQ2TQNJZGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hi Silo! Just like PR #29, your work here was a major inspiration for the rework in our develop branch. The discussion in this PR — Wayland vs X11, GTK vs a more abstract host — directly shaped the design decisions we made. We ended up implementing all three: Wayland, X11, and GTK3, each as a first-class host selectable via CMake flags, which is exactly the direction this conversation was heading. The Windows linking issue (roundf / libucrt) and the HarfBuzz integration challenges you ran into are all resolved in the new build — vcpkg handles the dependency graph cleanly across all platforms. Thank you for pushing this forward. Your contributions here were the seed of a lot of what landed in develop, and we hope you'll check it out! |
|
Tell me what you think! We can discuss it over at Discord if you want. |
I would like to propose replacing the implementation of the GTK window with the Wayland window. I am interested in using Elements on the Linux platform.