SDK: Fix certain uploads crashing instead of retrying on failed chunk#10375
Merged
SpecLad merged 1 commit intocvat-ai:developfrom Mar 16, 2026
Merged
SDK: Fix certain uploads crashing instead of retrying on failed chunk#10375SpecLad merged 1 commit intocvat-ai:developfrom
SpecLad merged 1 commit intocvat-ai:developfrom
Conversation
This was a regression introduced in d471db6. I hadn't realized that the `logger` parameter of `_upload_file_data_with_tus` was a _function_ rather than a logger object, so I used it as if it was the latter. I don't think the logger customization makes any sense here regardless, so just drop this parameter and use the client logger.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
bsekachev
pushed a commit
that referenced
this pull request
Mar 17, 2026
…#10375) This was a regression introduced in d471db6. I hadn't realized that the `logger` parameter of `_upload_file_data_with_tus` was a _function_ rather than a logger object, so I used it as if it was the latter. I don't think the logger customization makes any sense here regardless, so just drop this parameter and use the client logger.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and context
This was a regression introduced in d471db6. I hadn't realized that the
loggerparameter of_upload_file_data_with_tuswas a function rather than a logger object, so I used it as if it was the latter.I don't think the logger customization makes any sense here regardless, so just drop this parameter and use the client logger.
How has this been tested?
Checklist
developbranch[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)License
Feel free to contact the maintainers if that's a concern.