Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
klakhov
reviewed
Mar 23, 2026
Contributor
klakhov
left a comment
klakhov
left a comment
There was a problem hiding this comment.
Im okay with waiting for spinner after reload.
The same change should be done for line 103 i suppose
| +$shape.attr('x'), | ||
| +$shape.attr('y'), | ||
| ]; | ||
| cy.task('log', { xVal, yVal }); |
klakhov
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and context
We've recently had a failure of a negative test on interpolation in CI-Nightly. There appears to be a UI race condition after canvas reload where the coordinates are checked for the wrong object. Visually though, the rectangles are functioning correctly
0:32-0:33
issue_8952_interpolation_impossible.js.mp4
How has this been fixed?
Added assertions for no cvat-spinner and canvas visibility
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.