[ACHYDRA-971] Add meta nofollow and noindex tags to search results pages #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JackBlackLight
left a comment
JackBlackLight
left a comment
There was a problem hiding this comment.
Hey @goldsmithb, just had a few quick questions. Thanks!
| <%= render 'shared/google_analytics' %> | ||
| <%= render 'shared/highwire_press_tags' %> | ||
| <%= render 'shared/social_media_tags' %> | ||
| <%= render 'shared/meta_tags' %> |
Contributor
There was a problem hiding this comment.
this template includes blacklight base template at the bottom, so maybe we don't need to render meta_tags here as well?
| <%= vite_stylesheet_tag "embed.scss", media: "all" %> | ||
| <%= csrf_meta_tags %> | ||
| <%= content_for(:head) %> | ||
| <%= render 'shared/meta_tags' %> |
Contributor
There was a problem hiding this comment.
not sure about this one - but maybe? what was your rationale?
| end | ||
| end | ||
| end | ||
|
|
Contributor
There was a problem hiding this comment.
could you add a test for when nofollow and noindex should be false?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket
This PR adds meta tags to tell google scrapers not to index or follow links on search results pages.
We provide google a sitemap with all the pages we want indexed, so this prevents unnecessary requests from google's indexing scraper.
We add the 'noindex' and 'nofollow' rules to the following controller action(s):
We can easily add it to more actions, but this is the only one I could identify as needing it.