Skip to content

fix: restrict semantic tokens and completions to gherkin files#128

Open
zohnannor wants to merge 1 commit intocucumber:mainfrom
zohnannor:fix-semantic-highlighting
Open

fix: restrict semantic tokens and completions to gherkin files#128
zohnannor wants to merge 1 commit intocucumber:mainfrom
zohnannor:fix-semantic-highlighting

Conversation

@zohnannor
Copy link
Copy Markdown

🤔 What's changed?

Added a languageId check to the connection.languages.semanticTokens.on and connection.onCompletion handlers in CucumberLanguageServer.ts; if we are not in a 'gherkin' file, do nothing.

⚡️ What's your motivation?

Fixes cucumber/vscode#305

🏷️ What kind of change is this?

🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

N/A

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@zohnannor zohnannor force-pushed the fix-semantic-highlighting branch from debfb63 to 727ce02 Compare April 7, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Semantic syntax highlighting is applied in all files

1 participant