bugfix: crash when Cucumber::Messages::Group#children is nil - #1819
Merged
Conversation
luke-hill
approved these changes
Jan 29, 2026
luke-hill
left a comment
luke-hill
left a comment
Contributor
There was a problem hiding this comment.
Yep can see this. It's not really a problem because it was a breaking change that was pulled in without me considering the why
Contributor
|
I'm not sure why I made this change in advance, given it's not needed. For now a downgrade of the expressions library will suffice. Currently the Can you write a changelog message, it will be in the v11 release for certain |
vizv
force-pushed
the
bugfix-fix-map-on-nil-chilren
branch
from
January 30, 2026 03:22
c2663ce to
9f43ea1
Compare
Contributor
Author
|
I already wrote the changelog, just forgot to push 😂 |
luke-hill
reviewed
Jan 30, 2026
This change fixes the `undefined method 'map' for nil (NoMethodError)` for `cucumber-10.2.0/lib/cucumber/formatter/message_builder.rb:144`: `'Cucumber::Formatter::MessageBuilder#argument_group_to_message'` caused by: * Dec 11, 2025: cucumber#1805 allows to pull `cucumber-cucumber-expressions` `19.0.0` * Jan 21, 2026: cucumber/messages#370 introduce a breaking change that allows the `children` field of `Cucumber::Messages::Group` to be `nil` * Jan 21, 2026: cucumber/cucumber-expressions#387 `ruby/lib/cucumber/cucumber_expressions/group_builder.rb` sets the `children` to `nil` if `empty?` * Jan 26, 2026: The `cucumber-cucumber-expressions` `19.0.0` gem released and will be pulled in by `cucumber` `10.2.0` that raises the error The fix is simply accept the `nil` value for `Cucumber::Messages::Group#children`.
vizv
force-pushed
the
bugfix-fix-map-on-nil-chilren
branch
from
January 31, 2026 10:03
9f43ea1 to
06928ae
Compare
Contributor
|
Thankyou for this fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change fixes the
undefined method 'map' for nil (NoMethodError)forcucumber-10.2.0/lib/cucumber/formatter/message_builder.rb:144:'Cucumber::Formatter::MessageBuilder#argument_group_to_message'caused by:Dec 11, 2025: Updated deps of everything outside of core #1805 allows to pull
cucumber-cucumber-expressions19.0.0Jan 21, 2026: Make StepMatchArgument.Group.children optional messages#370 introduce a breaking change that allows the
childrenfield ofCucumber::Messages::Groupto benilJan 21, 2026: Make Group.children optional cucumber-expressions#387
ruby/lib/cucumber/cucumber_expressions/group_builder.rbsets thechildrentonilifempty?Jan 26, 2026: The
cucumber-cucumber-expressions19.0.0gem released and will be pulled in bycucumber10.2.0that raises the errorThe fix is simply accept the
nilvalue forCucumber::Messages::Group#children.Alternative fix
cucumber-cucumber-expressionsto< 20Type of change
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
bundle exec rubocopreports no offenses