Skip to content

docs: document the table chart's pivot presets - #11757

Merged
igorlukanin merged 2 commits into
masterfrom
igor/cub-4238-document-pivot-presets
Sep 4, 2026
Merged

docs: document the table chart's pivot presets#11757
igorlukanin merged 2 commits into
masterfrom
igor/cub-4238-document-pivot-presets

Conversation

@igorlukanin

Copy link
Copy Markdown
Member

The Pivot section of the table chart's Fields tab gains a presets menu, matching the one the Borders section already has. This documents both presets alongside the existing Border presets section.

Two smaller things while here:

  • The Pivots intro named a single "Pivot columns" drop zone. There are three — Rows, Columns and Values — plus the Measures placeholder, and the preset descriptions only make sense once those are named.
  • "values-as-rows layout" appeared twice with nothing explaining what it is or how to reach it. Both now link to the preset that produces it.

@mintlify

mintlify Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
cubed3 🟢 Ready View Preview Sep 3, 2026, 6:47 PM

💡 Tip: Enable Automations to automatically generate PRs for you.

@claude

claude Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 1m 29s —— View job


Docs review — looks good overall; 2 medium, 2 low, all inline

Review details
  • Read the PR diff against origin/master
  • Read both changed pages in full for context
  • Checked link targets and anchor uniqueness
  • Checked terminology consistency against docs-mintlify/CLAUDE.md
  • Posted findings as inline comments

Docs-only change to two .mdx pages under docs-mintlify — the active docs site, per CLAUDE.md. No code, no tests, nothing security- or performance-relevant, so the review is scoped to accuracy, consistency, and concision.

What's good

  • The new ### Pivot presets section mirrors #### Border presets closely — same "Open the menu in the corner of the … section to apply a preset — a one-shot … that you can rearrange further afterwards" framing, same **Name (default)** — description bullet shape. Easy to read alongside its sibling.
  • Both values-as-rows layout mentions now link somewhere, which was the stated goal. The cross-page link in querying-data.mdx:185 uses the right root-relative form (/docs/explore-analyze/charts/chart-types/table#pivot-presets), matching the /docs/... prefix used elsewhere on that page, and #pivot-presets doesn't collide with the page's other *presets headings (#border-presets, #rule-presets).
  • Naming the three drop zones is the right call — the preset descriptions genuinely don't parse without them.

Findings

# Severity Location Issue
1 Medium table.mdx:42 The "every dimension in Columns and nothing in Values" sentence is an orphan — not a preset, no stated relation to Vertical records, and appears to conflict with it
2 Medium table.mdx:44 The Reset-in-the-section-header claim isn't corroborated anywhere; the page scopes Reset buttons to the Style tab's sections. "Return to the default layout" also asserts something stronger than the Borders analogue
3 Low table.mdx:26 "Fields tab" vs the page's existing "Fields section" (lines 12, 101); the Measures placeholder is described but the reader isn't told how to move it
4 Low table.mdx:96 Line now ~105 chars against a paragraph wrapping at ~90

One thing I could not verify: the preset labels Table (default) and Vertical records, and the existence of the Pivot section's preset menu and Reset button. The chart UI isn't in this repo (grep for those strings hits only this .mdx), so #2 in particular needs a check against the actual product.

No prior threads on this PR, so nothing to resolve or deduplicate against.

· branch [`igor/cub-4238-document-pivot-presets`](https://github.com/cube-js/cube/tree/igor/cub-4238-document-pivot-presets)

Comment thread docs-mintlify/docs/explore-analyze/charts/chart-types/table.mdx Outdated
Comment thread docs-mintlify/docs/explore-analyze/charts/chart-types/table.mdx Outdated
Comment thread docs-mintlify/docs/explore-analyze/charts/chart-types/table.mdx Outdated
Comment thread docs-mintlify/docs/explore-analyze/charts/chart-types/table.mdx Outdated
@claude

claude Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Claude finished @igorlukanin's task in 1m 27s —— View job


Docs review (2nd pass) — all 4 prior findings addressed; 3 new low/medium nits, all inline

Review details
  • Diffed the new commit (10355d1) against the base
  • Checked each of my 4 prior threads against the current text
  • Re-read the Pivot and Border presets sections side by side
  • Re-checked link targets, anchors, and terminology
  • Posted new findings inline

Prior round: all four resolved

Prior finding Status
Orphan "headers alone" sentence Fixed — folded into the Vertical records bullet as the no-measures case, which is what it was actually about
Reset claim unverified / "default layout" wording Fixed — now states explicitly that it writes the Table (default) arrangement, plus the disabled condition
"Fields tab" vs "Fields section" Fixed — the Pivot section is now placed relative to the Fields section inside the Fields tab, so lines 12 and 112 stay correct. Nesting a Fields section inside a Fields tab is confusing, but that appears to be the product's own naming, and the added "below the … section that lists the columns" carries it
Over-long line at table.mdx:107 Fixed — re-wrapped at ~90

The Measures placeholder is also actionable now ("Drag it to Columns … or to Rows"), and the drop-zone list reads much better than the four-element sentence it replaced.

New findings (all in the ### Pivot presets block, all posted inline)

# Severity Location Issue
1 Medium table.mdx:45 "the three drop zones" contradicts the intro's own taxonomy — the presets also move the Measures placeholder, which the intro lists as a separate fourth item
2 Low table.mdx:47 Table (default) and Vertical records aren't parallel: only the latter names the Measures placeholder, so the pair doesn't read as transposes
3 Low table.mdx:54 "the two write the same layout" restates "restores the Table (default) arrangement"

Line 45 is also ~150 chars against the ~90 wrapping of the bullets around it, though it matches the unwrapped Border presets intro at line 393 — noted in the inline comment, not worth a separate finding.

Still unverifiable from this repo: the preset labels, the Pivot section's menu, and its Reset button. Grep for those strings hits only this .mdx, so the UI claims rest on your check against the product.

· branch [`igor/cub-4238-document-pivot-presets`](https://github.com/cube-js/cube/tree/igor/cub-4238-document-pivot-presets)


### Pivot presets

Open the menu in the corner of the Pivot section to apply a preset — a one-shot arrangement of the three drop zones that you can rearrange further afterwards:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"the three drop zones" undercounts what a preset actually writes. The intro above deliberately lists Rows, Columns, Values as the three drop zones and then the Measures placeholder as a separate fourth item — and Vertical records below is defined partly by moving that placeholder to Rows. As written, a reader who took the intro's taxonomy at face value will read the preset as leaving the placeholder alone.

Suggested change
Open the menu in the corner of the Pivot section to apply a preset — a one-shot arrangement of the three drop zones that you can rearrange further afterwards:
Open the menu in the corner of the **Pivot** section to apply a preset — a one-shot arrangement of the section's drop zones that you can rearrange further afterwards:

(Also bolds Pivot to match the intro; the Borders analogue's unbolded "Borders section" is the odd one out, not this.)

Comment on lines +47 to +48
- **Table (default)** — dimensions to **Rows**, measures to **Values**, measure names across the
top; the standard cross-tab.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two bullets aren't parallel. Vertical records spells out all four placements including the Measures placeholder, while Table (default) says "measure names across the top" without naming the placeholder that puts them there. Since the intro makes that placeholder the thing controlling top-vs-side, naming it in both is what lets the reader see the pair as transposes of each other:

Suggested change
- **Table (default)** — dimensions to **Rows**, measures to **Values**, measure names across the
top; the standard cross-tab.
- **Table (default)** — dimensions to **Rows**, measures to **Values**, and the **Measures**
placeholder to **Columns**, so the measure names run across the top; the standard cross-tab.

Comment on lines +54 to +55
**Reset**, beside the menu, restores the **Table (default)** arrangement — the two write the same
layout. It is disabled while the pivot already matches it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"restores the Table (default) arrangement" and "the two write the same layout" are the same fact stated twice — the second clause adds nothing once the first names the preset. Per the "say it once" guidance in docs-mintlify/CLAUDE.md:

Suggested change
**Reset**, beside the menu, restores the **Table (default)** arrangement — the two write the same
layout. It is disabled while the pivot already matches it.
**Reset**, beside the menu, restores the **Table (default)** arrangement. It is disabled while
the pivot already matches it.

The "disabled while it already matches" detail is the genuinely new information here and is worth keeping — it's more than the Borders analogue says about its own Reset.

@igorlukanin
igorlukanin merged commit a01db5c into master Sep 4, 2026
51 checks passed
@igorlukanin
igorlukanin deleted the igor/cub-4238-document-pivot-presets branch September 4, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant