docs: fill gaps from recent SQL API, dbt push, and deployment changes - #11698
docs: fill gaps from recent SQL API, dbt push, and deployment changes#11698keydunov wants to merge 5 commits into
Conversation
- SQL API: document same-data-source UNION/UNION ALL pushdown (#11651), multi-argument aggregate pushdown, and window functions over grouped subqueries/CTEs/joins (#11684) - dbt push: document the new Validation level setting (Parse/Compile/Build) and Validation schema field (CUB-4101) - Deployments: document the account-wide and per-user default landing deployment (CUB-4178) Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0111WWjfNRcHAa8HP7uXAKm7
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
Claude finished @keydunov's task in 2m 39s —— View job Review: docs gap-fill for SQL API pushdown, dbt push, default deploymentDocs-only change, well-scoped and correctly placed in Full review — findings, verification notes, todo listTodos
Findings
What checked out
Notes on the PR descriptionFlagging the missing funnel chart page as out of scope rather than folding it in was the right call. No test coverage applies (docs-only); |
PERCENTILE_CONT's documented form is single-argument (WITHIN GROUP), so "combined with other arguments" wasn't a real call shape. Use the actual example from the #11684 rule comment, and don't overstate pushdown as unconditional — it still depends on the target data source supporting the function. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0111WWjfNRcHAa8HP7uXAKm7
|
Claude finished @keydunov's task in 45s —— View job Docs review — new commit addresses 1 of 6 prior threads; 5 still open (all low/medium, wording & link consistency)Full review
What changed in
|
| File | Line | Concern |
|---|---|---|
reference/core-data-apis/sql-api/query-format.mdx |
211 | The new pushdown paragraph links [ref-query-default-limit] → /reference/core-data-apis/queries#row-limit, while the recipe it cross-links to says "maximum row limit" → /docs/data-modeling/configuration#maximum-row-limit. Same behaviour, two different limits named on the round trip. |
docs/preferences.mdx |
81 | Resolution order here omits "last deployment they switched to", contradicting admin/deployment/index.mdx:23-25. |
docs/integrations/dbt.mdx |
615 | Build in a validation schema vs. Build read as two settings; and the Validation schema row still says "Required when … Build" without saying what happens on BigQuery/Databricks/Athena, where the <Note> says Build falls back to Parse only. |
docs/integrations/dbt.mdx |
667 | "runs dbt deps plus the configured Validation level" — you run the check the level selects, not the level. |
reference/core-data-apis/sql-api/reference.mdx |
565 | "Two kinds are supported, including over a grouped subquery, CTE, or join" — the "including" clause modifies the wrong noun; it qualifies the window's input, not the two kinds. |
Each already has an unresolved thread with a suggestion block, so I didn't re-post.
One new, low-priority observation
reference.mdx:516 — "is no longer excluded from pushdown by its argument count" describes a delta rather than current behaviour. Reference docs are read by people who don't know which release changed what; "An aggregate function that takes more than one argument … can be pushed down, provided the target data source supports that function" says the same thing without dating itself. (This is my own suggested wording from the last pass, so: my miss — worth tightening before merge, not blocking.)
Verified clean
- All new anchors resolve:
#default-deployment(both pages),#list-of-deployments,#query-pushdown(query-format.mdx:195). - New link reference
[ref-cross-data-source-queries]is defined and points at an existing page. - All edits are in
/docs-mintlify(active site), none in the deprecated/docstree — matchesCLAUDE.md. - Mintlify component usage (
<Note>,<Step>) and root-relative internal links follow the repo conventions.
Nothing security-, performance-, or test-related applies: this PR is documentation only.
- Match the cross-data-source recipe's row-limit terminology and link
instead of introducing a second name for the same limit
- Restate the full default-deployment resolution order in preferences.mdx
so it doesn't contradict the admin page (last-switched-to was dropped)
- Fix the dbt push step 4 wording ("runs a validation level" -> "runs the
check the level selects")
- Fix window-function grammar: the grouped-subquery/CTE/join clause
qualifies the window's input, not "two kinds"
- Define Build in a validation schema / Build as the same setting on
first mention, and clarify the field is required by the form on every
adapter even though BigQuery/Databricks/Athena still only parse
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0111WWjfNRcHAa8HP7uXAKm7
|
I'll analyze this and get back to you. |
"No longer excluded" reads as a changelog note dating itself to a specific change; a reference page should just state what's true now. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0111WWjfNRcHAa8HP7uXAKm7
|
Addressed the tense observation from the second review pass too ( Generated by Claude Code |
|
Claude finished @keydunov's task in 1m 7s —— View job Docs review — all 6 prior threads addressed; no new blocking findings (0 high, 0 medium, 1 low nit)Full reviewTodos
What the last two commits fixed
All six threads are resolved (they were resolved by the author, not by me) and none of the concerns recur in the current text, so I posted no new inline comments. Re-verified against code
One low nit (non-blocking)
Still worth a maintainer's eye (not a defect)The row-limit consequence of union pushdown ("the limit applies once, to the combined result") is a reasonable inference from "pushed down as a single statement" but isn't something the rewrite rules state directly. Someone who has run the query should confirm it before merge. Nothing security-, performance-, or test-related applies: this PR is documentation only. · branch |
"Required ... on every adapter" read as a qualifier on the requirement itself rather than a pointer to the parse-only fallback described below. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0111WWjfNRcHAa8HP7uXAKm7
|
Claude finished @keydunov's task in 43s —— View job Docs review —
|

Summary
Routine scan of recent merges in
cube-js/cubeandcubedevinc/cubejs-enterprisefor customer-facing changes missing from docs-mintlify. Four small gaps found and closed with surgical edits to existing pages (no new pages needed):reference/core-data-apis/sql-api/query-format.mdx,reference.mdx,recipes/data-modeling/cross-data-source-queries.mdx):UNION/UNION ALLof queries that all reach the same data source is now pushed down as a single statement, so the row limit applies once to the combined result rather than per branch (feat(cubesql): Push UNION down to the data source #11651). Cross-referenced from the existing cross-data-source-queries recipe, which documents the still-unaffected per-branch case.docs/integrations/dbt.mdx): new Validation level setting (Parse only / Compile (recommended, default) / Build in a validation schema) and Validation schema field, plus the per-warehouse grant requirements and the three adapters (BigQuery, Databricks, Athena) that currently fall back to parse-only (cubedevinc/cubejs-enterprise#14392).admin/deployment/index.mdx,docs/preferences.mdx): accounts with multiple deployments can now set an account-wide default (admin) and/or a personal default (per user), with the resolution order documented (cubedevinc/cubejs-enterprise#14519).All four were verified against the actual diff/PR body (not just the commit subject) and confirmed absent from docs-mintlify before writing. No changes qualified as a "big" new-page-worthy feature in this pass, so no Linear ticket was needed.
One additional gap was found but intentionally not addressed here: the funnel chart type has no docs-mintlify page at all (missing from
chart-types/index.mdx), which predates the PR that added its horizontal-orientation option (cubedevinc/cubejs-enterprise#14510). Flagging for a separate pass rather than folding a new page into this change.Test plan
git show/PR body, not just the commit subjectGenerated by Claude Code